Going back to 9090 for ingress/filter metrics

[matzew]

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

Fixes #

Proposed Changes

• using "standard" 9090 port for metrics. I was moved to 9092 b/c it was planed to have broker run as KSVC, which we never really did. Related PRs: mt bits for 3162 #3181, Switch the metrics port of the Channel Based Broker components to 9092 #3162

Pre-review Checklist

• At least 80% unit test coverage
• E2E tests for any new behavior
• Docs PR for any user-facing impact
• Spec PR for any new API feature
• Conformance test for any change to the spec

Release Note

Broker ingress and filter pods use 9090 port for metrics.

Docs

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #5649 (2aa1046) into main (19fcdf4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5649   +/-   ##
=======================================
  Coverage   82.73%   82.73%           
=======================================
  Files         200      200           
  Lines        6266     6266           
=======================================
  Hits         5184     5184           
  Misses        750      750           
  Partials      332      332           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19fcdf4...2aa1046. Read the comment docs.

[matzew]

/assign @skonto

[n3wscott]

We still might use a ksvc for this though. This seems like unneeded churn.

[skonto]

We could switch to 9090 as the default (so we align all ports) and make broker ksvc setup a bit manual by documenting that:

A user can still set the broker exporter to listen to an arbitrary port eg. 9092 by modifying deployment yaml files and setting the corresponding env var METRICS_PROMETHEUS_PORT.

Additionally the Knative operator could support ksvc configuration of core components (eg. for auto-scaling) by setting the right configuration on the fly without user intervention.
In general it would be nice to document in Knative docs which ports are used for what by default (I think we miss that part).

[matzew]

/close
what ever...

[knative-prow-robot]

@matzew: Closed this PR.

Details

In response to this:

/close
what ever...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.