Skip to content

mt bits for 3162#3181

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
vaikas:broker-metric-ports
Jul 1, 2020
Merged

mt bits for 3162#3181
knative-prow-robot merged 1 commit into
knative:masterfrom
vaikas:broker-metric-ports

Conversation

@vaikas
Copy link
Copy Markdown
Contributor

@vaikas vaikas commented May 20, 2020

Fixes #

Proposed Changes

  • Same as 3162, but for mt broker.

Release Note

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 20, 2020
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 20, 2020
@vaikas
Copy link
Copy Markdown
Contributor Author

vaikas commented May 20, 2020

@Harwayne I think weed this as per your other PR?

@matzew
Copy link
Copy Markdown
Member

matzew commented May 26, 2020

@Harwayne ping?

@matzew
Copy link
Copy Markdown
Member

matzew commented Jun 30, 2020

/test pull-knative-eventing-unit-tests

@Harwayne
Copy link
Copy Markdown
Contributor

Harwayne commented Jun 30, 2020

@Harwayne I think weed this as per your other PR?

This is in regards to the change I made in #3162?

That was just about making sure the port declared on the Pod was the same as the one the code was using. It looks like the code for the MT Broker also uses 9092, so:

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2020
n3wscott
n3wscott reviewed Jul 1, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 1, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vaikas
Copy link
Copy Markdown
Contributor Author

vaikas commented Jul 1, 2020

@googlebot rescan

@chizhg
Copy link
Copy Markdown
Contributor

chizhg commented Jul 1, 2020

/retest

@knative-prow-robot knative-prow-robot merged commit 17b2978 into knative:master Jul 1, 2020
@vaikas vaikas deleted the broker-metric-ports branch July 1, 2020 23:53
@antoineco antoineco mentioned this pull request Sep 23, 2020
Merged
@matzew matzew mentioned this pull request Aug 20, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liu-cong liu-cong Awaiting requested review from liu-cong

1 more reviewer

@n3wscott n3wscott n3wscott left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Harwayne Harwayne

@n3wscott n3wscott

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@vaikas @matzew @Harwayne @knative-prow-robot @chizhg @n3wscott @googlebot