Fix metrics port mismatch between svc and deployment in broker manifests#4107
Conversation
| name: http | ||
| protocol: TCP | ||
| - containerPort: 9090 | ||
| - containerPort: 9092 |
There was a problem hiding this comment.
Corresponding Service:
eventing/config/brokers/mt-channel-broker/deployments/broker-filter.yaml
Lines 98 to 106 in 036711d
| name: http | ||
| protocol: TCP | ||
| - containerPort: 9090 | ||
| - containerPort: 9092 |
There was a problem hiding this comment.
Corresponding Service:
eventing/config/brokers/mt-channel-broker/deployments/broker-ingress.yaml
Lines 98 to 106 in 036711d
aliok
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Looks good, thanks @antoineco
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, antoineco, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Proposed Changes
It isn't clear from the manifests whether 9090 or 9092 is preferred, but the correct port is 9092:
eventing/cmd/mtbroker/filter/main.go
Lines 48 to 51 in af99921
See also #3181