Skip to content

Fix metrics port mismatch between svc and deployment in broker manifests #4107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 1 commit into from
Sep 24, 2020
Merged

Fix metrics port mismatch between svc and deployment in broker manifests #4107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/brokers/mt-channel-broker/deployments/broker-filter.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ spec:
- containerPort: 8080
name: http
protocol: TCP
- containerPort: 9090
- containerPort: 9092
Copy link
Copy Markdown
Contributor Author

@antoineco antoineco Sep 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corresponding Service:

eventing/config/brokers/mt-channel-broker/deployments/broker-filter.yaml

Lines 98 to 106 in 036711d

ports:
- name: http
port: 80
protocol: TCP
targetPort: 8080
- name: http-metrics
port: 9092
protocol: TCP
targetPort: 9092

name: metrics
protocol: TCP
terminationMessagePath: /dev/termination-log
Expand Down
2 changes: 1 addition & 1 deletion config/brokers/mt-channel-broker/deployments/broker-ingress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ spec:
- containerPort: 8080
name: http
protocol: TCP
- containerPort: 9090
- containerPort: 9092
Copy link
Copy Markdown
Contributor Author

@antoineco antoineco Sep 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corresponding Service:

eventing/config/brokers/mt-channel-broker/deployments/broker-ingress.yaml

Lines 98 to 106 in 036711d

ports:
- name: http
port: 80
protocol: TCP
targetPort: 8080
- name: http-metrics
port: 9092
protocol: TCP
targetPort: 9092

name: metrics
protocol: TCP
terminationMessagePath: /dev/termination-log
Expand Down