Add leader election#2501
Merged
Merged
Conversation
mattmoor
reviewed
Feb 4, 2020
knative-prow-robot
added
the
size/XXL
knative-prow-robot
added
the
do-not-merge/work-in-progress
pmorie
force-pushed
the
leader-election
branch
from
de08cd0 to
3bae0e9
Compare
mattmoor
reviewed
Feb 4, 2020
n3wscott
reviewed
Feb 4, 2020
| [[override]] | ||
| name = "knative.dev/pkg" | ||
| branch = "master" | ||
| source = "github.com/pmorie/pkg" |
Contributor
Author
There was a problem hiding this comment.
Do you mean DO or DO NOT
Contributor
|
Are you also suggesting that things like Broker should do this too? |
pmorie
force-pushed
the
leader-election
branch
from
3bae0e9 to
d28e0f1
Compare
mattmoor
reviewed
Feb 24, 2020
pmorie
force-pushed
the
leader-election
branch
from
d28e0f1 to
6c417ba
Compare
mattmoor
reviewed
Feb 24, 2020
knative-prow-robot
removed
the
do-not-merge/work-in-progress
pmorie
force-pushed
the
leader-election
branch
from
6c417ba to
4f1045d
Compare
mattmoor
reviewed
Feb 25, 2020
pmorie
force-pushed
the
leader-election
branch
from
4f1045d to
86d8ca8
Compare
mattmoor
reviewed
Feb 25, 2020
Contributor
Author
|
/retest |
Contributor
Author
|
It looks to me like the autoTLS failure is due to the issue that knative/serving#7014 fixes |
Contributor
|
/approve |
knative-prow-robot
added
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: n3wscott, pmorie The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
pmorie
force-pushed
the
leader-election
branch
from
86d8ca8 to
cf61a48
Compare
mattmoor
reviewed
Feb 26, 2020
pmorie
force-pushed
the
leader-election
branch
from
cf61a48 to
b0f6d9b
Compare
mattmoor
reviewed
Feb 26, 2020
mattmoor
reviewed
Feb 26, 2020
mattmoor
reviewed
Feb 26, 2020
pmorie
force-pushed
the
leader-election
branch
from
393a7ea to
15807ed
Compare
mattmoor
reviewed
Feb 26, 2020
| - watch | ||
| - create | ||
| - update | ||
| - patch No newline at end of file |
Member
There was a problem hiding this comment.
Add trailing newline:
Suggested change
| - patch | |
| - patch | |
| @@ -0,0 +1 @@ | |||
| core/configmaps/leader-election.yaml No newline at end of file | |||
Member
There was a problem hiding this comment.
Add trailing newline:
Suggested change
| core/configmaps/leader-election.yaml | |
| core/configmaps/leader-election.yaml | |
|
The following is the coverage report on the affected files.
|
Contributor
|
/lgtm |
knative-prow-robot
added
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes knative/pkg#1007
Proposed Changes
sharedmain, which is used by:/configis changed so that it is simple to enable leader election, but it is not enabled by defaultRelease Note