Skip to content

Wait for cert-manager pods to be running#7014

Merged
knative-prow-robot merged 2 commits into
knative:masterfrom
ZhiminXiang:wait_for_ready
Feb 25, 2020
Merged

Wait for cert-manager pods to be running#7014
knative-prow-robot merged 2 commits into
knative:masterfrom
ZhiminXiang:wait_for_ready

Conversation

@ZhiminXiang
Copy link
Copy Markdown

@ZhiminXiang ZhiminXiang commented Feb 25, 2020

Fixes #

Proposed Changes

  • Wait for cert-manager pods to be running

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 25, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 25, 2020
@ZhiminXiang ZhiminXiang requested a review from chaodaiG February 25, 2020 22:08
@knative-prow-robot knative-prow-robot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Feb 25, 2020
@ZhiminXiang
Copy link
Copy Markdown
Author

ZhiminXiang commented Feb 25, 2020

/assign @chaodaiG

vagababov
vagababov reviewed Feb 25, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2020
@pmorie pmorie mentioned this pull request Feb 25, 2020
Merged
@pmorie
Copy link
Copy Markdown
Contributor

pmorie commented Feb 25, 2020

@ZhiminXiang does this fix an issue where the autoTLS tests flake/fail because the cert isn't written yet?

@ZhiminXiang
Copy link
Copy Markdown
Author

ZhiminXiang commented Feb 25, 2020

@ZhiminXiang does this fix an issue where the autoTLS tests flake/fail because the cert isn't written yet?

Yea. trying to deflake the issue caused by cert-manager components not being ready.

@chaodaiG
Copy link
Copy Markdown
Contributor

chaodaiG commented Feb 25, 2020

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Feb 25, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG, ZhiminXiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2020
@knative-prow-robot knative-prow-robot merged commit 0eef24f into knative:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@dprotaso dprotaso Awaiting requested review from dprotaso

@tcnghia tcnghia Awaiting requested review from tcnghia

1 more reviewer

@vagababov vagababov vagababov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@vagababov vagababov

@chaodaiG chaodaiG

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ZhiminXiang @pmorie @chaodaiG @knative-prow-robot @vagababov @googlebot