Update VirtualSerivce to pass Istio validation#304
Merged
google-prow-robot merged 3 commits intoknative:masterfrom Aug 2, 2018
Merged
Update VirtualSerivce to pass Istio validation#304google-prow-robot merged 3 commits intoknative:masterfrom
google-prow-robot merged 3 commits intoknative:masterfrom
Conversation
The Istio validator was rejecting VirtualServices created for Channels. Adding the PortSelector made the validator happy again. Fixes knative#302
google-prow-robot
added
the
size/S
Contributor
Author
|
/assign @tcnghia |
tcnghia
reviewed
Aug 1, 2018
| Destination: istiov1alpha3.Destination{ | ||
| Host: destinationHost, | ||
| Port: istiov1alpha3.PortSelector{ | ||
| Number: 80, |
There was a problem hiding this comment.
do we already have a constant for this port number (or port name)?
google-prow-robot
added
size/M
scothis
force-pushed
the
istio-vs-validation
branch
from
54e3e67 to
4db8876
Compare
google-prow-robot
added
size/S
Contributor
Author
|
/test pull-knative-eventing-integration-tests At least the tests didn't fail for the reason this PR unblocks |
|
/lgtm |
...it causes 503s
Contributor
Author
|
Tests are passing now PTAL @tcnghia @evankanderson |
|
/lgtm |
Contributor
|
/cc @mattmoor This is needed to make the integration test pass. |
Contributor
|
/lgtm |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, scothis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
the
approved
n3wscott
pushed a commit
to n3wscott/eventing
that referenced
this pull request
Aug 3, 2018
* Update VirtualSerivce to pass Istio validation The Istio validator was rejecting VirtualServices created for Channels. Adding the PortSelector made the validator happy again. Fixes knative#302 * Use common PortName and PortNumber vars * Remove PortSelector Name ...it causes 503s
matzew
pushed a commit
to matzew/eventing
that referenced
this pull request
Oct 14, 2019
Applying 0.9.0 CI runs and patches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Istio validator was rejecting VirtualServices created for Channels.
Adding the PortSelector made the validator happy again.
Fixes #302