Skip to content

Pull feedlet image only if not present#291

Merged
google-prow-robot merged 1 commit intoknative:masterfrom
grantr:pull-if-not-present
Aug 3, 2018
Merged

Pull feedlet image only if not present#291
google-prow-robot merged 1 commit intoknative:masterfrom
grantr:pull-if-not-present

Conversation

@grantr
Copy link
Copy Markdown
Contributor

@grantr grantr commented Jul 26, 2018

This allows local images to be used, e.g. for minikube.

Fixes #284.

Proposed Changes

  • Change feedlet pod PullPolicy to IfNotPresent.

@grantr
Pull feedlet image only if not present
52be5ad 
This allows local images to be used, e.g. for minikube.
@google-prow-robot google-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 26, 2018
@grantr
Copy link
Copy Markdown
Contributor Author

grantr commented Jul 26, 2018

/cc @sslavic

@sslavic
Copy link
Copy Markdown

sslavic commented Jul 26, 2018

/lgtm

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2018
@grantr
Copy link
Copy Markdown
Contributor Author

grantr commented Jul 26, 2018

/cc @mattmoor @vaikas-google for approval

@google-prow-robot
Copy link
Copy Markdown

google-prow-robot commented Jul 26, 2018

@grantr: GitHub didn't allow me to request PR reviews from the following users: for, approval.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @mattmoor @vaikas-google for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@inlined
Copy link
Copy Markdown
Contributor

inlined commented Jul 27, 2018

/LGTM
/Approve

@google-prow-robot
Copy link
Copy Markdown

google-prow-robot commented Jul 27, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, inlined, sslavic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2018
@grantr
Copy link
Copy Markdown
Contributor Author

grantr commented Jul 30, 2018

/retest

@inlined
Copy link
Copy Markdown
Contributor

inlined commented Aug 1, 2018

Test failure seems related to istio/istio#6499. I'm honestly not sure if this is something to retest or not. If not you can assign to vaikas-google to take over from me as I'm going on vacation tonight.

/retest

@scothis
Copy link
Copy Markdown
Contributor

scothis commented Aug 1, 2018

The integration tests will fail until #304 is merged. They should hopefully work afterward.

@n3wscott
Copy link
Copy Markdown
Contributor

n3wscott commented Aug 3, 2018

/test pull-knative-eventing-integration-tests

@n3wscott
Copy link
Copy Markdown
Contributor

n3wscott commented Aug 3, 2018

/lgtm

@n3wscott
Copy link
Copy Markdown
Contributor

n3wscott commented Aug 3, 2018

/test pull-knative-eventing-integration-tests

@google-prow-robot google-prow-robot merged commit 8b0339f into knative:master Aug 3, 2018
n3wscott pushed a commit to n3wscott/eventing that referenced this pull request Aug 3, 2018
@grantr
Pull feedlet image only if not present (knative#291)
3e60a34 
This allows local images to be used, e.g. for minikube.
matzew pushed a commit to matzew/eventing that referenced this pull request Oct 10, 2019
@syedriko
Merge pull request knative#291 from matzew/remove_41_runs
3e8bde4 
No more 4.1 runs on next, just ocp 4.2
creydr pushed a commit to creydr/knative-eventing that referenced this pull request Jul 31, 2023
@pierDipi
Add eventshub service port name (knative#291)
8266e47 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inlined inlined Awaiting requested review from inlined

@ultrasaurus ultrasaurus Awaiting requested review from ultrasaurus

@mattmoor mattmoor Awaiting requested review from mattmoor

@vaikas vaikas Awaiting requested review from vaikas

1 more reviewer

@sslavic sslavic sslavic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sslavic sslavic

@inlined inlined

@n3wscott n3wscott

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@grantr @sslavic @google-prow-robot @inlined @scothis @n3wscott