Skip to content

Change backingchannel to return a combinedchannelable#3088

Merged
knative-prow-robot merged 12 commits into
knative:masterfrom
lberk:meta-channel-subscribers
May 8, 2020
Merged

Change backingchannel to return a combinedchannelable#3088
knative-prow-robot merged 12 commits into
knative:masterfrom
lberk:meta-channel-subscribers

Conversation

@lberk
Copy link
Copy Markdown
Member

@lberk lberk commented May 6, 2020

Fixes #3051

/wip

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 6, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 6, 2020
@lberk
Copy link
Copy Markdown
Member Author

lberk commented May 6, 2020

/hold
still a WIP

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2020
matzew
matzew reviewed May 6, 2020
View reviewed changes
Comment thread go.mod Outdated
@matzew
Copy link
Copy Markdown
Member

matzew commented May 6, 2020

/woof

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented May 6, 2020

@matzew: dog image

Details

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2020
vaikas
vaikas reviewed May 7, 2020
View reviewed changes
Comment thread pkg/reconciler/channel/channel.go
@lberk lberk force-pushed the meta-channel-subscribers branch from 92f6b08 to 071be2b Compare May 7, 2020 20:09
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2020
vaikas
vaikas reviewed May 7, 2020
View reviewed changes
Comment thread pkg/reconciler/channel/channel.go
@lberk
Copy link
Copy Markdown
Member Author

lberk commented May 7, 2020

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2020
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented May 7, 2020

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/channel/channel.go 75.5% 77.8% 2.3

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented May 8, 2020

/lgtm
/approve
Thanks!!!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented May 8, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lberk, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2020
@knative-prow-robot knative-prow-robot merged commit 6156771 into knative:master May 8, 2020
This was referenced May 8, 2020
Merged
Closed
Closed
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented May 12, 2020 •
edited
Loading

@lberk: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-eventing-build-tests 08c109e link /test pull-knative-eventing-build-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew matzew left review comments

@liu-cong liu-cong Awaiting requested review from liu-cong

+2 more reviewers

@mattmoor mattmoor mattmoor left review comments

@vaikas vaikas vaikas left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@vaikas vaikas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Meta Channel doesn't conform the spec's CRD spec.subscribers requirement

7 participants

@lberk @matzew @knative-prow-robot @knative-metrics-robot @vaikas @mattmoor @googlebot