Skip to content

[WIP] Port Channel tracing Test to new test images#3317

Closed
nlopezgi wants to merge 2 commits into
knative:masterfrom
nlopezgi:issue3267-6
Closed

[WIP] Port Channel tracing Test to new test images#3317
nlopezgi wants to merge 2 commits into
knative:masterfrom
nlopezgi:issue3267-6

Conversation

@nlopezgi
Copy link
Copy Markdown
Contributor

Part of #3267

WIP - cant figure out how to proceed debugging of this. Sending PR to ask for help.

Proposed Changes

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 12, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 12, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nlopezgi
To complete the pull request process, please assign chaodaig
You can assign the PR to them by writing /assign @chaodaig in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Jun 12, 2020
@nlopezgi
Copy link
Copy Markdown
Contributor Author

The e2e test is currently failing for me with the message:
TestChannelTracingWithReply/InMemoryChannel-messaging.knative.dev/v1beta1/includes_incoming_trace_id: channel_tracing_test_helper.go:119: Unable to get trace "347a0de2c8d003226f78b864804a2a55": timeout getting JSONTrace, most recent error: <nil>. Trace so far [{"timestamp":1591917900809142,"duration":825,"traceId":"347a0de2c8d003226f78b864804a2a55","id":"5886310b98f5b934","parentId":"1b8df92920c90d2f","name":"/","kind":"SERVER","localEndpoint":{"serviceName":"logger","ipv4":"10.60.2.78","port":80},"annotations":[{"timestamp":1591917900809164,"value":"Received 65 bytes"}],"tags":{"http.host":"logger.test-channel-tracing-with-reply-in-memory-channel-messaginds5ts.svc.cluster.local","http.method":"POST","http.path":"/","http.status_code":"202","http.url":"/","http.user_agent":"Go-http-client/1.1","opencensus.status_description":"OK"}},{"timestamp":1591917900766628,"duration":562,"traceId":"347a0de2c8d003226f78b864804a2a55","id":"7cfb2bc944279842","parentId":"64f1b891e13c82b7","name":"cloudevents.http./","kind":"SERVER","localEndpoint":{"serviceName":"transformer","ipv4":"10.60.0.66","port":80},"annotations":[{"timestamp":1591917900766644,"value":"Received 65 bytes"},{"timestamp":1591917900767161,"value":"Sent 65 bytes"}],"tags":{"http.host":"transformer.test-channel-tracing-with-reply-in-memory-channel-messaginds5ts.svc.cluster.local","http.method":"POST","http.path":"/","http.status_code":"200","http.url":"/","http.user_agent":"Go-http-client/1.1","opencensus.status_description":"OK"}}]

It was failing before with issues matching the expected span with the received one. I'm a bit stuck trying to debug, any help is appreciated.

fyi @slinkydeveloper

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@nlopezgi: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-eventing-integration-tests c2c4bc4 link /test pull-knative-eventing-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knative-test-reporter-robot
Copy link
Copy Markdown

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/conformance.TestChannelTracingWithReply
test/conformance.TestChannelTracingWithReply/Channel-messaging.knative.dev/v1beta1
test/conformance.TestChannelTracingWithReply/Channel-messaging.knative.dev/v1beta1/includes_incoming_trace_id
test/conformance.TestChannelTracingWithReply/InMemoryChannel-messaging.knative.dev/v1beta1
test/conformance.TestChannelTracingWithReply/InMemoryChannel-messaging.knative.dev/v1beta1/includes_incoming_trace_id

@slinkydeveloper
Copy link
Copy Markdown
Contributor

/close

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@slinkydeveloper: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants