Skip to content

Port Channel conformance tracing tests to new test images#3325

Merged
knative-prow-robot merged 4 commits into
knative:masterfrom
slinkydeveloper:pull/3317
Jun 16, 2020
Merged

Port Channel conformance tracing tests to new test images#3325
knative-prow-robot merged 4 commits into
knative:masterfrom
slinkydeveloper:pull/3317

Conversation

@slinkydeveloper
Copy link
Copy Markdown
Contributor

@slinkydeveloper slinkydeveloper commented Jun 16, 2020

Part of #3267

Supersedes #3317

Nicolas Lopez and others added 3 commits June 11, 2020 10:57
Port Channel event transformation for subscription Test to new test i…
f8754a0 
…mages
channel tracing test
c2c4bc4
@slinkydeveloper
Removed wrong SendEventWithTracing*
ba50b17 
Now tracing tests should just work

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 16, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 16, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release labels Jun 16, 2020
@slinkydeveloper slinkydeveloper changed the title [WIP] Port Channel conformance tracing tests [WIP] Port Channel conformance tracing tests to new test images Jun 16, 2020
@slinkydeveloper
Now using recordevents
5bd7e7d 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 16, 2020
@slinkydeveloper slinkydeveloper changed the title [WIP] Port Channel conformance tracing tests to new test images Port Channel conformance tracing tests to new test images Jun 16, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2020
devguyio
devguyio approved these changes Jun 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@devguyio devguyio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Can you please create an issue to refactor test/conformance/helpers/channel_tracing_test_helper.go : func setupChannelTracingWithReply ?

The function is gigantic and very hard to read. Specially the setup of traces and test data should be extracted out to some functions so that the main logic is clear in this function

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Abd4llA, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 132bb60 into knative:master Jun 16, 2020
@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

slinkydeveloper commented Jun 16, 2020

Can you please create an issue to refactor test/conformance/helpers/channel_tracing_test_helper.go : func setupChannelTracingWithReply ?

I wished to tackle that in this PR, but part of the code is reused in broker conformance tests. I'm going to refactor it together with porting the broker conformance test

@slinkydeveloper slinkydeveloper deleted the pull/3317 branch June 16, 2020 08:58
@slinkydeveloper slinkydeveloper mentioned this pull request Jun 16, 2020
Closed
17 tasks
@devguyio devguyio mentioned this pull request Jan 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@yt3liu yt3liu Awaiting requested review from yt3liu

1 more reviewer

@devguyio devguyio devguyio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@devguyio devguyio

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@slinkydeveloper @knative-prow-robot @devguyio @googlebot