Skip to content

Use some existing label#3341

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
matzew:annotation_usage
Jun 18, 2020
Merged

Use some existing label#3341
knative-prow-robot merged 1 commit into
knative:masterfrom
matzew:annotation_usage

Conversation

@matzew
Copy link
Copy Markdown
Member

@matzew matzew commented Jun 18, 2020

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

using proper label

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 18, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 18, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release labels Jun 18, 2020
Comment thread test/conformance/helpers/channel.go Outdated
eventingduckv1alpha1 "knative.dev/eventing/pkg/apis/duck/v1alpha1"
eventingduckv1beta1 "knative.dev/eventing/pkg/apis/duck/v1beta1"

messaging "knative.dev/eventing/pkg/apis/messaging"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the alias?

@devguyio
Copy link
Copy Markdown
Contributor

/assign

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew matzew force-pushed the annotation_usage branch from a9b5041 to 02a7613 Compare June 18, 2020 13:47
@devguyio
Copy link
Copy Markdown
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2020
@knative-prow-robot knative-prow-robot merged commit 454074f into knative:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants