Skip to content

Use some existing label #3341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 1 commit into from
Jun 18, 2020
Merged

Use some existing label #3341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions test/conformance/helpers/channel.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,10 @@ import (
eventingduckv1alpha1 "knative.dev/eventing/pkg/apis/duck/v1alpha1"
eventingduckv1beta1 "knative.dev/eventing/pkg/apis/duck/v1beta1"

"knative.dev/eventing/pkg/apis/messaging"
messagingv1beta1 "knative.dev/eventing/pkg/apis/messaging/v1beta1"
)

const (
SubscribableAnnotationKey = "messaging.knative.dev/subscribable"
)

var (
channelv1beta1GVK = (&messagingv1beta1.Channel{}).GetGroupVersionKind()

Expand All @@ -52,7 +49,7 @@ func getChannelDuckTypeSupportVersion(channelName string, client *lib.Client, ch
if !ok {
return "", errors.Wrapf(err, "Unable to cast the channel %v", metaResource)
}
return channelable.ObjectMeta.Annotations[SubscribableAnnotationKey], nil
return channelable.ObjectMeta.Annotations[messaging.SubscribableDuckVersionAnnotation], nil
}

func getChannelAsV1Beta1Channelable(channelName string, client *lib.Client, channel metav1.TypeMeta) (*eventingduckv1beta1.Channelable, error) {
Expand Down