Skip to content

Removed cloudevents/sdk-go v1#3345

Merged
knative-prow-robot merged 3 commits into
knative:masterfrom
slinkydeveloper:remove_sdk-go_v1
Jun 18, 2020
Merged

Removed cloudevents/sdk-go v1#3345
knative-prow-robot merged 3 commits into
knative:masterfrom
slinkydeveloper:remove_sdk-go_v1

Conversation

@slinkydeveloper
Copy link
Copy Markdown
Contributor

@slinkydeveloper slinkydeveloper commented Jun 18, 2020

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Removes cloudevents/sdk-go v1

@slinkydeveloper
Removed cloudevents/sdk-go v1
34d8d83 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 18, 2020
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 18, 2020
@slinkydeveloper
Readded thirdy party dir
06b73c7 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
pierDipi
pierDipi reviewed Jun 18, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think those deletions need a follow up in eventing-contrib, right?
Might it be better to migrate eventing-contrib components first?

Unhold if you feel it's not necessary.

/lgtm
/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2020
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2020
@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

slinkydeveloper commented Jun 18, 2020

/unhold

all the eventing-contrib components are already migrated 😉

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2020
@slinkydeveloper
nit
95b1327 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2020
@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

slinkydeveloper commented Jun 18, 2020

/assign @n3wscott

@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Jun 18, 2020

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/utils/headers.go Do not exist 0.0%

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 18, 2020 •
edited
Loading

@slinkydeveloper: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-eventing-go-coverage 95b1327 link /test pull-knative-eventing-go-coverage

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@n3wscott
Copy link
Copy Markdown
Contributor

n3wscott commented Jun 18, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [n3wscott,slinkydeveloper]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit cac2338 into knative:master Jun 18, 2020
@slinkydeveloper slinkydeveloper deleted the remove_sdk-go_v1 branch June 18, 2020 19:39
@zargarpur zargarpur mentioned this pull request Jun 19, 2020
Closed
@nachocano nachocano mentioned this pull request Jun 22, 2020
Merged
@pierDipi pierDipi mentioned this pull request Sep 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierDipi pierDipi pierDipi left review comments

@grantr grantr Awaiting requested review from grantr

@liu-cong liu-cong Awaiting requested review from liu-cong

Assignees

@n3wscott n3wscott

@pierDipi pierDipi

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@slinkydeveloper @knative-metrics-robot @knative-prow-robot @n3wscott @pierDipi @googlebot