Add pierDipi to approvers

[pierDipi]

Criteria: https://github.com/knative/community/blob/master/ROLES.md#approver

• Reviewer of the codebase for at least 3 months. first review (May) ➡️ set trigger status appropriately if they do not have broker #3144

• Primary reviewer for at least 10 substantial PRs to the codebase (10 + 1 bonus): (unclear what substantial means 🙂)

  • ➡️ add post 017 job to remove pingsource finalizer #3836
  • ➡️ kubectl explain for Broker #3848
  • ➡️ kubectl explain for Trigger #3845
  • ➡️ Conformance tests for channel control plane aggregated addressable resolver ClusterRole #3219
  • ➡️ Now eventTracker.Cleanup() is invoked behind the hood #3780
  • ➡️ retry on webhook failures #3678
  • ➡️ add channel v1 duck type to spec #3870
  • ➡️ Add Broker control plane tests for Broker v1beta1 #3214
  • ➡️ Subscription v1<>v1beta conversion #3421
  • ➡️ remove the channel-broker configs and release files #3547
  • ➡️ JS expressions for trigger filter #3771 (open)

• Reviewed at least 30 PRs to the codebase ➡️ 46

  • ➡️ Update channel.md #4091
  • ➡️ remove reference to persisted store #4090
  • ➡️ Proper logging for filter handler malformed response #4083
  • ➡️ [master] Format markdown #4068
  • ➡️ Moving constant #4048
  • ➡️ [master] Auto-update dependencies #4047
  • ➡️ Add retries for webhook fails at conformance tests #4045
  • ➡️ Remove unnecessary whitelist terminology. #4025
  • ➡️ Remove 'master' where not necessary and add tracking issues. #4022
  • ➡️ Refactor main functions to reuse helpers from package. #4021
  • ➡️ remove unused triggerlister #3996
  • ➡️ Retry channel spec update in conformance tests #3971
  • ➡️ Updating broker to be v1 #3956
  • ➡️ remove a rando sleep, testing to see if it is still needed #3898
  • ➡️ do not use resp if it fails, use 0 instead #3897
  • ➡️ Add explicit content encoding to event-senders in broker conf test #3885
  • ➡️ Adding small test for util #3879
  • ➡️ Add docs on how to run conf tests against preexisting broker #3872
  • ➡️ add channel v1 duck type to spec #3870
  • ➡️ kubectl explain for Broker #3848
  • ➡️ kubectl explain for Trigger #3845
  • ➡️ add post 017 job to remove pingsource finalizer #3836
  • ➡️ Use apis.HTTP() #3830
  • ➡️ Test Client now has a Cleanup method #3828
  • ➡️ Clean-up of old borker deployments… #3820
  • ➡️ Adding ttlSecondsAfterFinished to broker clean up… #3815
  • ➡️ Now eventTracker.Cleanup() is invoked behind the hood #3780
  • ➡️ JS expressions for trigger filter #3771
  • ➡️ Regroup additional printer columns #3770
  • ➡️ put the waiting of kresources in a retry loop for webhook failures #3751
  • ➡️ replace fatalf with logf in retry loop #3734
  • ➡️ Retry in case of update conflicts #3731
  • ➡️ retry on webhook failures #3678
  • ➡️ add step for installing sugar for e2e #3670
  • ➡️ add broker developers as system integrator personas #3668
  • ➡️ Return an error if the test client cannot getTracingConfig #3608
  • ➡️ don't force using /bin/bash #3597
  • ➡️ generate reconcilers for flows.* v1 resources #3586
  • ➡️ remove the channel-broker configs and release files #3547
  • ➡️ nil check on addressable #3543
  • ➡️ use eventing as label instead of serving #3445
  • ➡️ Subscription v1<>v1beta conversion #3421
  • ➡️ Removed cloudevents/sdk-go v1 #3345
  • ➡️ Conformance tests for channel control plane aggregated addressable resolver ClusterRole #3219
  • ➡️ Add Broker control plane tests for Broker v1beta1 #3214
  • ➡️ set trigger status appropriately if they do not have broker #3144

• Nominated by a WG lead (with no objections from other leads): @lionelvillard

Proposed Changes

• Add pierDipi to approvers

/assign @grantr @lionelvillard @vaikas
/cc @grantr @lionelvillard @vaikas

[lionelvillard]

🎉 Thanks @pierDipi for the hard work!

/lgtm

@vaikas @grantr

[slinkydeveloper]

woooo definitely +1 for your nomination! /lgtm

[matzew]

/lgtm
very well deserved

[vaikas]

/lgtm

[aliok]

Congrats @pierDipi 🎉

FWIW:
/lgtm

[grantr]

unclear what substantial means 🙂

Typically it's meant the PR has size/L or greater, but this is not explicitly defined (and size is easy to game by reviewing PRs that alter dependencies). 3 of the substantial reviews listed here are size/M, but this query shows 11 size/L PRs reviewed.

/lgtm

Thanks for all your contributions @pierDipi!

[grantr]

All leads lgtm

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [grantr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment