Adding small test for util#3879
Conversation
mattmoor
left a comment
There was a problem hiding this comment.
Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)
mattmoor
left a comment
There was a problem hiding this comment.
Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)
mattmoor
left a comment
There was a problem hiding this comment.
Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)
6adbebc to
d49d6f1
Compare
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
2b02c26 to
94864c2
Compare
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
|
The following is the coverage report on the affected files.
|
|
The following jobs failed:
Job pull-knative-eventing-upgrade-tests expended all 3 retries without success. |
|
/retest |
pierDipi
left a comment
There was a problem hiding this comment.
Always good to have more tests.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Matthias Wessendorf mwessend@redhat.com
Fixes #
Proposed Changes
Release Note
Docs