Skip to content

Adding ttlSecondsAfterFinished to broker clean up…#3815

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
matzew:ttlSecondsAfterFinished_for_job
Aug 11, 2020
Merged

Adding ttlSecondsAfterFinished to broker clean up…#3815
knative-prow-robot merged 1 commit into
knative:masterfrom
matzew:ttlSecondsAfterFinished_for_job

Conversation

@matzew
Copy link
Copy Markdown
Member

@matzew matzew commented Aug 11, 2020

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 11, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 11, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2020
Copy link
Copy Markdown
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit f132f49 into knative:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants