Add explicit content encoding to event-senders in broker conf test#3885
Conversation
knative-prow-robot
added
the
size/S
knative-prow-robot
added
the
area/test-and-release
|
/test pull-knative-eventing-unit-tests |
pierDipi
left a comment
pierDipi
left a comment
There was a problem hiding this comment.
We got the same error message:
2020/08/19 20:10:01 Got response from http://broker-ingress.knative-eventing-pxo9jvqv7n.svc.cluster.local/test-broker-v1-beta1-data-plane-ingress-5gf5g/br
failed to convert response into event: unknown Message encoding
Such error message comes from the event-sender (https://github.com/knative/eventing/blob/master/test/test_images/event-sender/main.go#L158), and I think it's expected.
|
/retest |
|
It's just noise, but we should probably clean this up indeed. |
|
Why didn't @vaikas approval work... |
|
/lgtm |
|
/approve |
knative-prow-robot
added
the
approved
|
@lberk looks like this doesn't have the 'wait for service endpoint' (based on the test failure), mind rebasing? |
knative-prow-robot
added
the
needs-rebase
Realted: knative#3791 For broker data plane conformance tests, when observing some of the errors in pod sender logs, the following message was seen: "Got response from http://broker-ingress.knative-eventing-28b9ei2f23.svc.cluster.local/test-broker-v1-beta1-data-plane-consumer-wzjjv/br failed to convert response into event: unknown Message encoding" Add a `sender.WithEncoding(ce.EncodingStructured)` option to the event sender in an attempt to make the conformance tests more robust.
lberk
force-pushed
the
robustify-broker-dataplane-tests
branch
from
7fc23fc to
8cfd160
Compare
knative-prow-robot
removed
lgtm
|
@vaikas done |
|
The following jobs failed:
Failed non-flaky tests preventing automatic retry of pull-knative-eventing-conformance-tests: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantr, lberk, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9 participants
Realted: #3791
For broker data plane conformance tests, when observing some of the
errors in pod sender logs, the following message was seen:
"Got response from http://broker-ingress.knative-eventing-28b9ei2f23.svc.cluster.local/test-broker-v1-beta1-data-plane-consumer-wzjjv/br
failed to convert response into event: unknown Message encoding"
Add a
sender.WithEncoding(ce.EncodingStructured)option to the eventsender in an attempt to make the conformance tests more robust.
Make broker conformance tests more robust