remove a rando sleep, testing to see if it is still needed by n3wscott · Pull Request #3898 · knative/eventing

n3wscott · 2020-08-20T19:55:57Z

No description provided.

knative-prow-robot · 2020-08-20T19:56:03Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

n3wscott · 2020-08-20T19:56:21Z

/test pull-knative-eventing-integration-tests

mattmoor

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)

mattmoor · 2020-08-20T19:56:31Z

@@ -18,8 +18,6 @@ package lib

 import (
 	"fmt"


Format Go code:

Suggested change

"fmt"

"fmt"

n3wscott · 2020-08-20T20:59:33Z

1/1 passed.

/test pull-knative-eventing-integration-tests

n3wscott · 2020-08-20T21:53:16Z

2/2 passed.

/test pull-knative-eventing-integration-tests

n3wscott · 2020-08-21T00:23:21Z

3/3 passed.

/test pull-knative-eventing-integration-tests

knative-test-reporter-robot · 2020-08-21T00:26:42Z

The following jobs failed:

Test name	Triggers	Retries
pull-knative-eventing-conformance-tests		0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-conformance-tests:

.Up

knative-test-reporter-robot · 2020-08-21T00:26:42Z

The following jobs failed:

Test name	Triggers	Retries
pull-knative-eventing-integration-tests		0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

.Up

pierDipi · 2020-08-21T07:38:59Z

This issue might be related: #3686

vaikas · 2020-08-21T17:46:05Z

Both tests failed with this. Not related.

NG: Starting with version 1.18, clusters will have shielded GKE nodes by default.
WARNING: Your Pod address range (`--cluster-ipv4-cidr`) can accommodate at most 1008 node(s). 
This will enable the autorepair feature for nodes. Please see https://cloud.google.com/kubernetes-engine/docs/node-auto-repair for more information on node autorepairs.
ERROR: (gcloud.beta.container.clusters.create) ResponseError: code=503, message=The service is currently unavailable.
Error: error creating clusters: error creating cluster: exit status 1
Step failed: ./test/e2e-tests.sh
+ EXIT_VALUE=1
+ set +o xtrace

WARNING: Starting with version 1.18, clusters will have shielded GKE nodes by default.
WARNING: Your Pod address range (`--cluster-ipv4-cidr`) can accommodate at most 1008 node(s). 
This will enable the autorepair feature for nodes. Please see https://cloud.google.com/kubernetes-engine/docs/node-auto-repair for more information on node autorepairs.
ERROR: (gcloud.beta.container.clusters.create) ResponseError: code=503, message=The service is currently unavailable.
Error: error creating clusters: error creating cluster: exit status 1
Step failed: ./test/e2e-conformance-tests.sh
+ EXIT_VALUE=1
+ set +o xtrace

vaikas · 2020-08-21T17:46:17Z

/test pull-knative-eventing-integration-tests

vaikas · 2020-08-21T18:20:12Z

/test pull-knative-eventing-conformance-tests

aliok · 2020-08-24T07:17:51Z

/test pull-knative-eventing-conformance-tests

aliok · 2020-08-24T07:51:53Z

Retest worked, but perhaps only for this time.

Previous failed build: https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_eventing/3898/pull-knative-eventing-conformance-tests/1296875005098856450

    monitoring.go:71: running recordevents port-forward in background, pid = 50882
=== CONT  TestChannelTracingWithReply/InMemoryChannel-messaging.knative.dev/v1
    event_info_store.go:245: Timeout waiting for at least 1 matches.
        Error: FAIL MATCHING: saw 0/1 matching events.
        Recent events: 
        0 events seen, last 0 events:
        Match errors: 
        
        
        knative.dev/eventing/test/lib/recordevents.(*EventInfoStore).AssertAtLeast
        	/home/prow/go/src/knative.dev/eventing/test/lib/recordevents/event_info_store.go:245
        knative.dev/eventing/test/conformance/helpers.tracingTest
        	/home/prow/go/src/knative.dev/eventing/test/conformance/helpers/tracing_test_helper.go:72
        knative.dev/eventing/test/conformance/helpers.ChannelTracingTestHelperWithChannelTestRunner.func1
        	/home/prow/go/src/knative.dev/eventing/test/conformance/helpers/channel_tracing_test_helper.go:43
        knative.dev/eventing/test/lib.(*ComponentsTestRunner).RunTests.func1
        	/home/prow/go/src/knative.dev/eventing/test/lib/test_runner.go:72
        testing.tRunner
        	/root/.gvm/gos/go1.14.6/src/testing/testing.go:1039
        runtime.goexit
        	/root/.gvm/gos/go1.14.6/src/runtime/asm_amd64.s:1373

aliok · 2020-08-24T07:52:10Z

/test pull-knative-eventing-conformance-tests

matzew · 2020-08-24T13:29:38Z

/test pull-knative-eventing-conformance-tests

matzew · 2020-08-24T13:29:44Z

/test pull-knative-eventing-integration-tests

n3wscott · 2020-08-26T17:12:09Z

/test pull-knative-eventing-conformance-tests
/test pull-knative-eventing-integration-tests

n3wscott · 2020-08-27T16:49:05Z

welll.... /tableflip

vaikas · 2020-08-27T17:54:28Z

This failed with the eventinfo store:

    event_info_store.go:245: Timeout waiting for at least 1 matches.
        Error: FAIL MATCHING: saw 0/1 matching events.
        Recent events: 
        0 events seen, last 0 events:
        Match errors: 
        
        
        knative.dev/eventing/test/lib/recordevents.(*EventInfoStore).AssertAtLeast
        	/home/prow/go/src/knative.dev/eventing/test/lib/recordevents/event_info_store.go:245
        knative.dev/eventing/test/e2e/helpers.SequenceTestHelper.func1
        	/home/prow/go/src/knative.dev/eventing/test/e2e/helpers/sequence_test_helper.go:146
        knative.dev/eventing/test/lib.(*ComponentsTestRunner).RunTests.func1
        	/home/prow/go/src/knative.dev/eventing/test/lib/test_runner.go:72
        testing.tRunner
        	/root/.gvm/gos/go1.14.6/src/testing/testing.go:1039
        runtime.goexit
        	/root/.gvm/gos/go1.14.6/src/runtime/asm_amd64.s:1373

#3570

pierDipi

/lgtm
/retest

knative-prow-robot · 2020-09-17T10:31:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/OWNERS~~ [n3wscott]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pierDipi · 2020-09-17T12:44:18Z

docs/source/receive-adapter.md
	ERROR	https://github.com/knative/eventing-contrib/tree/master/github
		Not Found (HTTP error 404)

/cc @lionelvillard

pierDipi · 2020-09-17T13:01:00Z

/retest

pierDipi · 2020-09-17T14:09:32Z

=== CONT  TestChannelTracingWithReply/Channel-messaging.knative.dev/v1
    event_info_store.go:246: Timeout waiting for at least 1 matches.
        Error: FAIL MATCHING: saw 0/1 matching events.
        Recent events: 
        0 events seen, last 0 events:
        Match errors: 
        
        
        knative.dev/eventing/test/lib/recordevents.(*EventInfoStore).AssertAtLeast
        	/home/prow/go/src/knative.dev/eventing/test/lib/recordevents/event_info_store.go:246
        knative.dev/eventing/test/conformance/helpers.tracingTest
        	/home/prow/go/src/knative.dev/eventing/test/conformance/helpers/tracing_test_helper.go:74
        knative.dev/eventing/test/conformance/helpers.ChannelTracingTestHelperWithChannelTestRunner.func1
        	/home/prow/go/src/knative.dev/eventing/test/conformance/helpers/channel_tracing_test_helper.go:45
        knative.dev/eventing/test/lib.(*ComponentsTestRunner).RunTests.func1
        	/home/prow/go/src/knative.dev/eventing/test/lib/test_runner.go:75
        testing.tRunner
        	/root/.gvm/gos/go1.14.6/src/testing/testing.go:1039
        runtime.goexit
        	/root/.gvm/gos/go1.14.6/src/runtime/asm_amd64.s:1373

/retest

pierDipi · 2020-09-17T15:03:53Z

This is interesting, I've never seen it before:

=== CONT  TestChannelChannelableManipulatorClusterRoleTest/InMemoryChannel-messaging.knative.dev/v1beta1
    rbac.go:46: Operation "get" is not allowed on inmemorychannels.messaging.knative.dev/v1beta1 subresource:""

n3wscott · 2020-09-17T17:29:42Z

/retest

pierDipi · 2020-09-22T05:58:27Z

/retest

pierDipi · 2020-09-22T07:11:36Z

=== CONT  TestBrokerTracing/Channel-messaging.knative.dev/v1
    event_info_store.go:246: Timeout waiting for at least 1 matches.
        Error: FAIL MATCHING: saw 0/1 matching events.
        Recent events: 
        0 events seen, last 0 events:
        Match errors: 
        
        
        knative.dev/eventing/test/lib/recordevents.(*EventInfoStore).AssertAtLeast
        	/home/prow/go/src/knative.dev/eventing/test/lib/recordevents/event_info_store.go:246
        knative.dev/eventing/test/conformance/helpers.tracingTest
        	/home/prow/go/src/knative.dev/eventing/test/conformance/helpers/tracing_test_helper.go:74
        knative.dev/eventing/test/conformance/helpers.BrokerTracingTestHelperWithChannelTestRunner.func1
        	/home/prow/go/src/knative.dev/eventing/test/conformance/helpers/broker_tracing_test_helper.go:47
        knative.dev/eventing/test/lib.(*ComponentsTestRunner).RunTests.func1
        	/home/prow/go/src/knative.dev/eventing/test/lib/test_runner.go:75
        testing.tRunner
        	/root/.gvm/gos/go1.14.6/src/testing/testing.go:1039
        runtime.goexit
        	/root/.gvm/gos/go1.14.6/src/runtime/asm_amd64.s:1373

/retest

pierDipi · 2020-10-02T14:24:07Z

/retest

pierDipi · 2020-10-19T14:50:08Z

/retest

n3wscott · 2020-10-20T00:03:22Z

/retest

pierDipi · 2020-10-29T21:01:33Z

/retest

pierDipi · 2020-10-30T08:09:14Z

Apparently, removing this random sleep makes our CI jobs unstable. 🤔

pierDipi · 2020-10-30T08:18:34Z

/lgtm cancel

pierDipi · 2020-10-30T08:19:22Z

/retest

knative-prow-robot · 2020-10-30T09:00:45Z

@n3wscott: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-knative-eventing-integration-tests	`52490f6`	link	`/test pull-knative-eventing-integration-tests`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tayarani · 2020-11-25T21:59:57Z

@n3wscott is there consensus that we still need the sleep? should we close this?

n3wscott · 2020-12-02T22:04:07Z

/close

reconciler-test will not use a sleep

knative-prow-robot · 2020-12-02T22:04:14Z

@n3wscott: Closed this PR.

Details

In response to this:

/close

reconciler-test will not use a sleep

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

remove a rando sleep, testing to see if it is still needed

52490f6

knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2020

googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 20, 2020

knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 20, 2020

knative-prow-robot requested review from chaodaiG and steuhs August 20, 2020 19:56

knative-prow-robot added area/test-and-release Test infrastructure, tests or release approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 20, 2020

mattmoor reviewed Aug 20, 2020

View reviewed changes

n3wscott marked this pull request as ready for review August 21, 2020 00:23

knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2020

pierDipi approved these changes Sep 17, 2020

View reviewed changes

knative-prow-robot assigned pierDipi Sep 17, 2020

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2020

knative-prow-robot requested a review from lionelvillard September 17, 2020 12:44

pierDipi mentioned this pull request Sep 17, 2020

Change link to GitHubSource #4067

Merged

pierDipi mentioned this pull request Sep 22, 2020

Add pierDipi to approvers #4095

Merged

knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2020

knative-prow-robot closed this Dec 2, 2020

pierDipi mentioned this pull request Mar 15, 2021

WIP: Try to remove artificial sleeps #5066

Closed

Conversation

n3wscott commented Aug 20, 2020

Uh oh!

knative-prow-robot commented Aug 20, 2020

Uh oh!

n3wscott commented Aug 20, 2020

Uh oh!

mattmoor left a comment

Choose a reason for hiding this comment

Uh oh!

mattmoor Aug 20, 2020

Choose a reason for hiding this comment

Uh oh!

n3wscott commented Aug 20, 2020

Uh oh!

n3wscott commented Aug 20, 2020

Uh oh!

n3wscott commented Aug 21, 2020

Uh oh!

knative-test-reporter-robot commented Aug 21, 2020

Uh oh!

knative-test-reporter-robot commented Aug 21, 2020

Uh oh!

pierDipi commented Aug 21, 2020

Uh oh!

vaikas commented Aug 21, 2020

Uh oh!

vaikas commented Aug 21, 2020

Uh oh!

vaikas commented Aug 21, 2020

Uh oh!

aliok commented Aug 24, 2020

Uh oh!

aliok commented Aug 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aliok commented Aug 24, 2020

Uh oh!

matzew commented Aug 24, 2020

Uh oh!

matzew commented Aug 24, 2020

Uh oh!

n3wscott commented Aug 26, 2020

Uh oh!

n3wscott commented Aug 27, 2020

Uh oh!

vaikas commented Aug 27, 2020

Uh oh!

pierDipi left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow-robot commented Sep 17, 2020

Uh oh!

pierDipi commented Sep 17, 2020

Uh oh!

pierDipi commented Sep 17, 2020

Uh oh!

pierDipi commented Sep 17, 2020

Uh oh!

pierDipi commented Sep 17, 2020

Uh oh!

n3wscott commented Sep 17, 2020

Uh oh!

pierDipi commented Sep 22, 2020

Uh oh!

pierDipi commented Sep 22, 2020

Uh oh!

pierDipi commented Oct 2, 2020

Uh oh!

pierDipi commented Oct 19, 2020

Uh oh!

n3wscott commented Oct 20, 2020

Uh oh!

pierDipi commented Oct 29, 2020

Uh oh!

pierDipi commented Oct 30, 2020

Uh oh!

pierDipi commented Oct 30, 2020

Uh oh!

pierDipi commented Oct 30, 2020

aliok commented Aug 24, 2020 •

edited

Loading