Skip to content

Now eventTracker.Cleanup() is invoked behind the hood#3780

Merged
knative-prow-robot merged 3 commits into
knative:masterfrom
slinkydeveloper:record_events_cleanup
Aug 5, 2020
Merged

Now eventTracker.Cleanup() is invoked behind the hood#3780
knative-prow-robot merged 3 commits into
knative:masterfrom
slinkydeveloper:record_events_cleanup

Conversation

@slinkydeveloper
Copy link
Copy Markdown
Contributor

@slinkydeveloper slinkydeveloper commented Aug 5, 2020 •
edited
Loading

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Proposed Changes

@slinkydeveloper
Now eventTracker.Cleanup() is invoked behind the hood
a5274d1 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 5, 2020
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 5, 2020
pierDipi
pierDipi reviewed Aug 5, 2020
View reviewed changes
Comment thread test/lib/recordevents/event_info_store.go
@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Aug 5, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/e2e.TestApiServerSourceV1Beta1EventTypes

@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

slinkydeveloper commented Aug 5, 2020

/retest

@slinkydeveloper
Reinstated Cleanup method, but it's noop
fd5d4d6 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
little mistake
d335149 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
pierDipi
pierDipi approved these changes Aug 5, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Aug 5, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit f6789d8 into knative:master Aug 5, 2020
@slinkydeveloper slinkydeveloper deleted the record_events_cleanup branch August 5, 2020 11:50
@slinkydeveloper slinkydeveloper mentioned this pull request Aug 7, 2020
Merged
@pierDipi pierDipi mentioned this pull request Sep 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierDipi pierDipi pierDipi approved these changes

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@chizhg chizhg Awaiting requested review from chizhg

Assignees

@pierDipi pierDipi

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@slinkydeveloper @knative-test-reporter-robot @knative-prow-robot @pierDipi @googlebot