Skip to content

Test Client now has a Cleanup method#3828

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
slinkydeveloper:reducing_ci_flakyness_hopefully
Aug 13, 2020
Merged

Test Client now has a Cleanup method#3828
knative-prow-robot merged 1 commit into
knative:masterfrom
slinkydeveloper:reducing_ci_flakyness_hopefully

Conversation

@slinkydeveloper
Copy link
Copy Markdown
Contributor

@slinkydeveloper slinkydeveloper commented Aug 13, 2020

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Fixes #

Proposed Changes

  • Client now has a Cleanup method to hook the lifecycle of the event tracker to the client. This should avoid the tracker to continue working after the test is finished (and hopefully fix related flakyness)

@slinkydeveloper
client now has a cleanup method to hook lifecycle of event tracker to…
33e7e1c 
… the client lifecycle

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 13, 2020
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release labels Aug 13, 2020
@slinkydeveloper slinkydeveloper mentioned this pull request Aug 13, 2020
Closed
@pierDipi
Copy link
Copy Markdown
Member

pierDipi commented Aug 13, 2020

/test pull-knative-eventing-conformance-tests

2 similar comments
@pierDipi
Copy link
Copy Markdown
Member

pierDipi commented Aug 13, 2020

/test pull-knative-eventing-conformance-tests

@pierDipi
Copy link
Copy Markdown
Member

pierDipi commented Aug 13, 2020

/test pull-knative-eventing-conformance-tests

@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

slinkydeveloper commented Aug 13, 2020

Mhh seems like this is still flaky...

@pierDipi
Copy link
Copy Markdown
Member

pierDipi commented Aug 13, 2020

No, it seems a nice green history https://prow.knative.dev/pr-history/?org=knative&repo=eventing&pr=3828

@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

slinkydeveloper commented Aug 13, 2020

Well, then let's try to ship it 😍

@lionelvillard

@pierDipi
Copy link
Copy Markdown
Member

pierDipi commented Aug 13, 2020

/test pull-knative-eventing-conformance-tests

What isn't clear to me is the actual behavioral change for that particular flaky test, that uses only one client and pass it to the helper that then registers T.Cleanup functions when it creates the two stores.

@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

slinkydeveloper commented Aug 13, 2020

What isn't clear to me is the actual behavioral change for that particular flaky test, that uses only one client and pass it to the helper that then registers T.Cleanup functions when it creates the two stores.

I suspect the behavioural change might be around how cleanup is called in t between parent and child t? I'm not 100% sure, mine is just a guess 😄 Let's try to retest a bunch of times more and let's see if this fixes it, i suspect this might solve also another problem i have with port-forward

@pierDipi
Copy link
Copy Markdown
Member

pierDipi commented Aug 13, 2020

/test pull-knative-eventing-conformance-tests

pierDipi
pierDipi approved these changes Aug 13, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Aug 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Copy Markdown
Member

pierDipi commented Aug 13, 2020

/test pull-knative-eventing-conformance-tests

@knative-prow-robot knative-prow-robot merged commit 06a1822 into knative:master Aug 13, 2020
@slinkydeveloper slinkydeveloper deleted the reducing_ci_flakyness_hopefully branch August 13, 2020 18:10
@pierDipi pierDipi mentioned this pull request Sep 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierDipi pierDipi pierDipi approved these changes

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@chizhg chizhg Awaiting requested review from chizhg

Assignees

@pierDipi pierDipi

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@slinkydeveloper @pierDipi @knative-prow-robot @googlebot