Skip to content

[WIP] Log event record#3679

Closed
slinkydeveloper wants to merge 13 commits into
knative:masterfrom
slinkydeveloper:log_event_record
Closed

[WIP] Log event record#3679
slinkydeveloper wants to merge 13 commits into
knative:masterfrom
slinkydeveloper:log_event_record

Conversation

@slinkydeveloper
Copy link
Copy Markdown
Contributor

@slinkydeveloper slinkydeveloper commented Jul 22, 2020

Testing knative/pkg#1538

Proposed Changes

  • Use new port-forwarding code with logging

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 22, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 22, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 22, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2020
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Jul 22, 2020
@slinkydeveloper slinkydeveloper force-pushed the log_event_record branch 2 times, most recently from 5c0ed51 to 28eb20e Compare July 22, 2020 12:50
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2020
@knative-prow-robot knative-prow-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 24, 2020
@knative-prow-robot knative-prow-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 27, 2020
@slinkydeveloper
client now has a cleanup method to hook lifecycle of event tracker to…
da5b80c 
… the client lifecycle

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Log when server is starting in recordevents
1f0e4b3 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Log when server is starting in recordevents
98865a5 
Updated pkg

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
update pkg
e8f1b89 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Trying the new port-forward code
2e694b9 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
pointing to my fork
cd38b53 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Update
1ac736a 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Stuff
dd688e4 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Updates
e2a7af6 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Added defer to event trackers
fcb6858 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Tried to make cleanup private
586938c 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Update
d021d01 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
sli
b706cd6 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2020
@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

slinkydeveloper commented Aug 13, 2020

Trying to combine this one with #3828

@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Aug 13, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-conformance-tests 2020-08-13 14:08:29.551 +0000 UTC 1/3

Automatically retrying due to test flakiness...
/test pull-knative-eventing-conformance-tests

@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Aug 13, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-integration-tests 2020-08-13 14:08:29.551 +0000 UTC 1/3

Automatically retrying due to test flakiness...
/test pull-knative-eventing-integration-tests

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Aug 13, 2020

@slinkydeveloper: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-eventing-unit-tests b706cd6 link /test pull-knative-eventing-unit-tests
pull-knative-eventing-build-tests b706cd6 link /test pull-knative-eventing-build-tests
pull-knative-eventing-upgrade-tests b706cd6 link /test pull-knative-eventing-upgrade-tests
pull-knative-eventing-conformance-tests b706cd6 link /test pull-knative-eventing-conformance-tests
pull-knative-eventing-integration-tests b706cd6 link /test pull-knative-eventing-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Aug 13, 2020

@slinkydeveloper: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matzew
Copy link
Copy Markdown
Member

matzew commented Sep 25, 2020

@slinkydeveloper what's the status here ?

@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

slinkydeveloper commented Oct 5, 2020

Closing in favour of #4171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chizhg chizhg Awaiting requested review from chizhg

@yolocs yolocs Awaiting requested review from yolocs

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@slinkydeveloper @knative-prow-robot @knative-test-reporter-robot @matzew @googlebot