Replacing port-forwarding with k8s events in recordevents

[slinkydeveloper]

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Fixes #3570

Proposed Changes

• This PR takes the ideas from pkg/test/observer and ports them to recordevents, without changing the API. This change is meant to be transparent both here in eventing and in downstream projects.
• Reorganizes some code of recordevents to make it more "self-contained" (simpler to port to newer test framework).

[mattmoor]

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)

[mattmoor]

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)

[mattmoor]

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)

[mattmoor]

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)

[mattmoor]

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)

[mattmoor]

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)

[slinkydeveloper]

/assign @lionelvillard @n3wscott

@n3wscott Can i remove the code under pkg/test/observer? At this point that code is orphan and not used in this repo (I've moved the bits i needed and modified them under test/lib/recordevents)

[lionelvillard]

In reconciler-test the event informer is injected into the context (something to keep in mind when moving this code over).

[slinkydeveloper]

Cool so we can avoid creating it manually!

[slinkydeveloper]

We'll still need this EventListener, right? Note that this is shared between different EventInfoStore

[lionelvillard]

Yup I think so.

[knative-test-reporter-robot]

The following jobs failed:

Test name	Triggers	Retries
pull-knative-eventing-conformance-tests		0/3
pull-knative-eventing-upgrade-tests		0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-conformance-tests:

test/conformance.TestBrokerV1Beta1DataPlaneIngress/MTChannelBasedBroker-eventing.knative.dev/v1beta1
test/conformance.TestBrokerV1Beta1DataPlaneIngress
test/conformance.TestBrokerV1Beta1ControlPlane/MTChannelBasedBroker-eventing.knative.dev/v1beta1/Trigger_V1Beta1_can_be_crated_before_Broker_(with_attributes_filter)
test/conformance.TestBrokerV1Beta1ControlPlane/MTChannelBasedBroker-eventing.knative.dev/v1beta1
test/conformance.TestBrokerV1Beta1ControlPlane
test/conformance.TestChannelForwardHeadersPrependedWithKnative/InMemoryChannel-messaging.knative.dev/v1beta1
test/conformance.TestChannelForwardHeadersPrependedWithKnative/Channel-messaging.knative.dev/v1
test/conformance.TestChannelForwardHeadersPrependedWithKnative/Channel-messaging.knative.dev/v1beta1

and 47 more.

[knative-test-reporter-robot]

The following jobs failed:

Test name	Triggers	Retries
pull-knative-eventing-integration-tests		0/3
pull-knative-eventing-upgrade-tests		0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/e2e.TestDefaultBrokerWithManyTriggers/test_default_broker_with_many_attribute_triggers
test/e2e.TestDefaultBrokerWithManyTriggers/test_default_broker_with_many_attribute_and_extension_triggers
test/e2e.TestDefaultBrokerWithManyTriggers/test_default_broker_with_many_deprecated_triggers
test/e2e.TestDefaultBrokerWithManyTriggers/test_default_broker_with_many_attribute_triggers_using_v1beta1_trigger
test/e2e.TestDefaultBrokerWithManyTriggers
test/e2e.TestApiServerSourceV1/event-ref
test/e2e.TestApiServerSourceV1/event-ref-match-label-expr
test/e2e.TestApiServerSourceV1/event-ref-unmatch-label

and 35 more.

[n3wscott]

why are you copying this to test/lib?

[n3wscott]

now we have three copies of this code?

[slinkydeveloper]

Because that code is hard to reuse, I had to do some important changes (interfaces and impls looks similar, but they're different)

[slinkydeveloper]

That's why I'm saying, if we use that code only in recordevents, what if we just remove the one under test/lib?

[slinkydeveloper]

now we have three copies of this code?

Copying to the new test framework was a mistake, i'm going to port this new code there 😄

[slinkydeveloper]

The issue here is weird, for some reason it timeouts on waiting for pods to delete

[slinkydeveloper]

Solved, I was not closing the http server correctly

[slinkydeveloper]

/retest

[n3wscott]

/lgtm
/approve

[n3wscott]

NICE FIND!!!

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [n3wscott,slinkydeveloper]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[matzew]

@slinkydeveloper is it possible to backport this to 0.17 and 0.18 ? 😁

[slinkydeveloper]

@matzew Not sure for 0.17, changes are too much extensive both on recordevents and lib test code... There are also other changes in that code before this one. If we need it i can work on it but that's not a trivial port :) 0.18 might be doable