Reuse recordevents as transformevents by slinkydeveloper · Pull Request #4291 · knative/eventing

slinkydeveloper · 2020-10-12T15:10:45Z

This simplifies the debugging of the tests, since recordevents sends the events to k8s logs

In the followup PRs I'll remove transformevents and sequence-stepper because they're not longer useful with this PR

Proposed Changes

Now recordevents has a configurable reply function to behave like transformevents

codecov · 2020-10-12T15:16:38Z

Codecov Report

❗ No coverage uploaded for pull request base (master@2078491). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #4291   +/-   ##
=========================================
  Coverage          ?   80.32%           
=========================================
  Files             ?      287           
  Lines             ?     7892           
  Branches          ?        0           
=========================================
  Hits              ?     6339           
  Misses            ?     1172           
  Partials          ?      381

Impacted Files	Coverage Δ
pkg/mtbroker/filter/stats_reporter.go	`87.30% <100.00%> (ø)`
pkg/mtbroker/ingress/stats_reporter.go	`87.75% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2078491...33db128. Read the comment docs.

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

knative-prow-robot · 2020-10-13T13:36:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [slinkydeveloper]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

slinkydeveloper · 2020-10-13T13:46:01Z

This one is ready to go, @n3wscott @lionelvillard wanna check this out?

lionelvillard · 2020-10-13T14:31:31Z

/lgtm

slinkydeveloper · 2020-10-13T14:32:40Z

I'm pretty sure the kind issue is not related to this PR, it's a failure in source_sinkbinding_v1_test.go:121

slinkydeveloper · 2020-10-13T15:35:21Z

/retest

* transformevents done Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * transformevents done Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Test Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Fix copyright Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Did something Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit d5d4f42) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Replacing port-forwarding with k8s events in recordevents (#4171) * WIP Replacing port-forwarding with k8s events in recordevents Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * WIP Events are sent properly from recordevents to k8s events Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Sending the beast in battle Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Update Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Moved resources of recordevents in proper module Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * gofmt Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Another one Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Other stuff Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Copyrights Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Other copyrights Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * boilerplate check Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * boilerplate check Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Other lints checks Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Warn Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Now the linter Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Missing decorator in recordevents Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Simplified the sink definition, just sending events to myself Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Happy linter, happy me Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Correct HTTP server shutdown Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Try fix correlator config Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Just close the server Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Still messing up with the Event correlator options Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * lint check Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit b7a7126) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Reuse recordevents as transformevents (#4291) * transformevents done Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * transformevents done Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Test Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Fix copyright Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Did something Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit d5d4f42) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Using recordevents as sequencestepper (#4313) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 656ab81) * Remove transformevents usages (#4309) * Remove transformevents Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Comments Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Let's be less breaky: brought back the image Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 3e7f942) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Fixes after cherry pick Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Remove sequence stepper usages (#4344) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 515f416) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Remove filterevents usages (#4347) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit ca85d86) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> # Conflicts: # test/lib/resources/kube.go * Update Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Not sure why SYSTEM_NAMESPACE doesn't work in 0.17 Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Did the same error 2 times Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* transformevents done Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * transformevents done Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Test Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Fix copyright Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Did something Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit d5d4f42) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Reuse recordevents as transformevents (#4291) * transformevents done Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * transformevents done Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Test Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Fix copyright Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Did something Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit d5d4f42) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Using recordevents as sequencestepper (#4313) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 656ab81) * Remove transformevents usages (#4309) * Remove transformevents Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Comments Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Let's be less breaky: brought back the image Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 3e7f942) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Remove sequence stepper usages (#4344) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 515f416) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Remove filterevents usages (#4347) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit ca85d86) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Fix Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 12, 2020

knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 12, 2020

knative-prow-robot requested review from chaodaiG and yt3liu October 12, 2020 15:10

knative-prow-robot added area/test-and-release Test infrastructure, tests or release approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 12, 2020

slinkydeveloper force-pushed the transformevents branch from 1aa70fd to fa1257c Compare October 12, 2020 15:34

slinkydeveloper added 5 commits October 13, 2020 15:13

transformevents done

3ff1182

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

transformevents done

5454c5d

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

Test

5dcd3c1

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

Fix copyright

699adcc

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

Did something

33db128

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

slinkydeveloper force-pushed the transformevents branch from 0641015 to 33db128 Compare October 13, 2020 13:35

knative-prow-robot assigned lionelvillard Oct 13, 2020

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2020

knative-prow-robot merged commit d5d4f42 into knative:master Oct 13, 2020

slinkydeveloper deleted the transformevents branch October 13, 2020 17:13

This was referenced Oct 13, 2020

Remove transformevents usages #4309

Merged

Using recordevents as sequencestepper #4313

Merged

Port transformevents test image knative-extensions/reconciler-test#23

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reuse recordevents as transformevents#4291

Reuse recordevents as transformevents#4291
knative-prow-robot merged 5 commits into
knative:masterfrom
slinkydeveloper:transformevents

slinkydeveloper commented Oct 12, 2020

Uh oh!

codecov Bot commented Oct 12, 2020 •

edited

Loading

Uh oh!

knative-prow-robot commented Oct 13, 2020

Uh oh!

slinkydeveloper commented Oct 13, 2020 •

edited

Loading

Uh oh!

lionelvillard commented Oct 13, 2020

Uh oh!

slinkydeveloper commented Oct 13, 2020

Uh oh!

slinkydeveloper commented Oct 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

slinkydeveloper commented Oct 12, 2020

Proposed Changes

Uh oh!

codecov Bot commented Oct 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

knative-prow-robot commented Oct 13, 2020

Uh oh!

slinkydeveloper commented Oct 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lionelvillard commented Oct 13, 2020

Uh oh!

slinkydeveloper commented Oct 13, 2020

Uh oh!

slinkydeveloper commented Oct 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Oct 12, 2020 •

edited

Loading

slinkydeveloper commented Oct 13, 2020 •

edited

Loading