Using recordevents as sequencestepper by slinkydeveloper · Pull Request #4313 · knative/eventing

slinkydeveloper · 2020-10-14T08:38:58Z

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

This enables recordevents to act as sequencestepper. For more info on why: #4291

Proposed Changes

Now recordevents can act as sequencestepper

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

slinkydeveloper · 2020-10-14T08:39:22Z

cc @lionelvillard

codecov · 2020-10-14T08:45:57Z

Codecov Report

Merging #4313 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4313   +/-   ##
=======================================
  Coverage   80.36%   80.36%           
=======================================
  Files         288      288           
  Lines        7910     7910           
=======================================
  Hits         6357     6357           
  Misses       1172     1172           
  Partials      381      381

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0889429...f6a7db9. Read the comment docs.

vaikas · 2020-10-14T11:55:16Z

/lgtm
/approve
/hold
@slinkydeveloper remove the hold if it's good to go with downstream.

knative-prow-robot · 2020-10-14T11:55:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slinkydeveloper, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/OWNERS~~ [slinkydeveloper,vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

slinkydeveloper · 2020-10-14T12:37:49Z

/unhold

Downstream shouldn't be impacted, i'm gonna remove the images in another pr. This just removes the usage

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 656ab81)

* Replacing port-forwarding with k8s events in recordevents (#4171) * WIP Replacing port-forwarding with k8s events in recordevents Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * WIP Events are sent properly from recordevents to k8s events Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Sending the beast in battle Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Update Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Moved resources of recordevents in proper module Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * gofmt Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Another one Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Other stuff Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Copyrights Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Other copyrights Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * boilerplate check Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * boilerplate check Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Other lints checks Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Warn Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Now the linter Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Missing decorator in recordevents Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Simplified the sink definition, just sending events to myself Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Happy linter, happy me Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Correct HTTP server shutdown Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Try fix correlator config Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Just close the server Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Still messing up with the Event correlator options Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * lint check Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit b7a7126) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Reuse recordevents as transformevents (#4291) * transformevents done Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * transformevents done Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Test Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Fix copyright Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Did something Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit d5d4f42) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Using recordevents as sequencestepper (#4313) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 656ab81) * Remove transformevents usages (#4309) * Remove transformevents Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Comments Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Let's be less breaky: brought back the image Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 3e7f942) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Fixes after cherry pick Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Remove sequence stepper usages (#4344) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 515f416) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Remove filterevents usages (#4347) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit ca85d86) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> # Conflicts: # test/lib/resources/kube.go * Update Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Not sure why SYSTEM_NAMESPACE doesn't work in 0.17 Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Did the same error 2 times Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 656ab81)

* Reuse recordevents as transformevents (#4291) * transformevents done Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * transformevents done Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Test Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Fix copyright Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Did something Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit d5d4f42) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Using recordevents as sequencestepper (#4313) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 656ab81) * Remove transformevents usages (#4309) * Remove transformevents Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Comments Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Let's be less breaky: brought back the image Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 3e7f942) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Remove sequence stepper usages (#4344) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 515f416) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Remove filterevents usages (#4347) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit ca85d86) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Fix Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

Using recordevents as sequencestepper

f6a7db9

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 14, 2020

knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 14, 2020

knative-prow-robot requested review from steuhs and yt3liu October 14, 2020 08:39

knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2020

knative-prow-robot assigned vaikas Oct 14, 2020

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2020

knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2020

knative-prow-robot merged commit 656ab81 into knative:master Oct 14, 2020

slinkydeveloper deleted the remove_sequencestepper branch October 14, 2020 12:49

slinkydeveloper mentioned this pull request Oct 14, 2020

Remove sequencestepper knative-extensions/reconciler-test#24

Closed

slinkydeveloper added a commit to slinkydeveloper/eventing that referenced this pull request Oct 20, 2020

Using recordevents as sequencestepper (knative#4313)

5e0c3c9

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 656ab81)

slinkydeveloper mentioned this pull request Oct 20, 2020

Removed sequence stepper usages #4344

Merged

slinkydeveloper added a commit to slinkydeveloper/eventing that referenced this pull request Oct 20, 2020

Using recordevents as sequencestepper (knative#4313)

4c5cef6

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 656ab81)

slinkydeveloper added a commit to slinkydeveloper/eventing that referenced this pull request Oct 23, 2020

Using recordevents as sequencestepper (knative#4313)

c268c01

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 656ab81)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Using recordevents as sequencestepper#4313

Using recordevents as sequencestepper#4313
knative-prow-robot merged 1 commit into
knative:masterfrom
slinkydeveloper:remove_sequencestepper

slinkydeveloper commented Oct 14, 2020 •

edited

Loading

Uh oh!

slinkydeveloper commented Oct 14, 2020

Uh oh!

codecov Bot commented Oct 14, 2020

Uh oh!

vaikas commented Oct 14, 2020

Uh oh!

knative-prow-robot commented Oct 14, 2020

Uh oh!

slinkydeveloper commented Oct 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

slinkydeveloper commented Oct 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Uh oh!

slinkydeveloper commented Oct 14, 2020

Uh oh!

codecov Bot commented Oct 14, 2020

Codecov Report

Uh oh!

vaikas commented Oct 14, 2020

Uh oh!

knative-prow-robot commented Oct 14, 2020

Uh oh!

slinkydeveloper commented Oct 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

slinkydeveloper commented Oct 14, 2020 •

edited

Loading