Remove filterevents usages#4347
Merged
knative-prow-robot merged 1 commit intoOct 20, 2020
Merged
Conversation
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
knative-prow-robot
added
the
size/M
knative-prow-robot
added
approved
Codecov Report
@@ Coverage Diff @@
## master #4347 +/- ##
=======================================
Coverage 80.81% 80.81%
=======================================
Files 288 288
Lines 8001 8001
=======================================
Hits 6466 6466
Misses 1147 1147
Partials 388 388 Continue to review full report at Codecov.
|
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slinkydeveloper, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
slinkydeveloper
added a commit
to slinkydeveloper/eventing
that referenced
this pull request
Oct 20, 2020
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit ca85d86) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> # Conflicts: # test/lib/resources/kube.go
knative-prow-robot
pushed a commit
that referenced
this pull request
Oct 20, 2020
* Replacing port-forwarding with k8s events in recordevents (#4171) * WIP Replacing port-forwarding with k8s events in recordevents Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * WIP Events are sent properly from recordevents to k8s events Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Sending the beast in battle Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Update Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Moved resources of recordevents in proper module Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * gofmt Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Another one Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Other stuff Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Copyrights Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Other copyrights Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * boilerplate check Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * boilerplate check Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Other lints checks Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Warn Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Now the linter Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Missing decorator in recordevents Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Simplified the sink definition, just sending events to myself Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Happy linter, happy me Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Correct HTTP server shutdown Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Try fix correlator config Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Just close the server Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Still messing up with the Event correlator options Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * lint check Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit b7a7126) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Reuse recordevents as transformevents (#4291) * transformevents done Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * transformevents done Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Test Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Fix copyright Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Did something Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit d5d4f42) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Using recordevents as sequencestepper (#4313) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 656ab81) * Remove transformevents usages (#4309) * Remove transformevents Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Comments Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Let's be less breaky: brought back the image Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 3e7f942) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Fixes after cherry pick Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Remove sequence stepper usages (#4344) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 515f416) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Remove filterevents usages (#4347) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit ca85d86) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> # Conflicts: # test/lib/resources/kube.go * Update Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Not sure why SYSTEM_NAMESPACE doesn't work in 0.17 Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Did the same error 2 times Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
slinkydeveloper
added a commit
to slinkydeveloper/eventing
that referenced
this pull request
Oct 23, 2020
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit ca85d86) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
knative-prow-robot
pushed a commit
that referenced
this pull request
Oct 23, 2020
* Reuse recordevents as transformevents (#4291) * transformevents done Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * transformevents done Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Test Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Fix copyright Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Did something Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit d5d4f42) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Using recordevents as sequencestepper (#4313) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 656ab81) * Remove transformevents usages (#4309) * Remove transformevents Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Comments Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Let's be less breaky: brought back the image Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 3e7f942) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Remove sequence stepper usages (#4344) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit 515f416) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Remove filterevents usages (#4347) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit ca85d86) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Fix Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Francesco Guardiani francescoguard@gmail.com
Removed filterevents usages and replaces with recordevents
Proposed Changes