Skip to content

[0.17] Port recordevents#4355

Merged
knative-prow-robot merged 10 commits into
knative:release-0.17from
slinkydeveloper:port_recordevents
Oct 20, 2020
Merged

[0.17] Port recordevents#4355
knative-prow-robot merged 10 commits into
knative:release-0.17from
slinkydeveloper:port_recordevents

Conversation

@slinkydeveloper
Copy link
Copy Markdown
Contributor

This includes several ports of recent CI stability improvements around recordevents image

* WIP Replacing port-forwarding with k8s events in recordevents

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* WIP Events are sent properly from recordevents to k8s events

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Sending the beast in battle

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Update

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Moved resources of recordevents in proper module

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* gofmt

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Another one

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Other stuff

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Copyrights

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Other copyrights

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* boilerplate check

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* boilerplate check

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Other lints checks

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Warn

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Now the linter

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Missing decorator in recordevents

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Simplified the sink definition, just sending events to myself

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Happy linter, happy me

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Correct HTTP server shutdown

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Try fix correlator config

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Just close the server

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Still messing up with the Event correlator options

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* lint check

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

(cherry picked from commit b7a7126)
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
* transformevents done

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* transformevents done

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Test

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Fix copyright

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Did something

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

(cherry picked from commit d5d4f42)
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
(cherry picked from commit 656ab81)
* Remove transformevents

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Comments

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Let's be less breaky: brought back the image

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

(cherry picked from commit 3e7f942)
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

(cherry picked from commit 515f416)
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
(cherry picked from commit ca85d86)
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

# Conflicts:
#	test/lib/resources/kube.go
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 20, 2020
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Oct 20, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 20, 2020
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

/test pull-knative-eventing-conformance-tests

@lberk
Copy link
Copy Markdown
Member

lberk commented Oct 20, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2020
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2020
@lberk
Copy link
Copy Markdown
Member

lberk commented Oct 20, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2020
@knative-prow-robot knative-prow-robot merged commit 8133ced into knative:release-0.17 Oct 20, 2020
@slinkydeveloper slinkydeveloper deleted the port_recordevents branch October 21, 2020 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants