Skip to content

Remove transformevents usages#4309

Merged
knative-prow-robot merged 3 commits into
knative:masterfrom
slinkydeveloper:remove_transformevents
Oct 14, 2020
Merged

Remove transformevents usages#4309
knative-prow-robot merged 3 commits into
knative:masterfrom
slinkydeveloper:remove_transformevents

Conversation

@slinkydeveloper
Copy link
Copy Markdown
Contributor

@slinkydeveloper slinkydeveloper commented Oct 13, 2020

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Follow up of #4291

Proposed Changes

@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 13, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 13, 2020
@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

cc @n3wscott @lionelvillard

@knative-prow-robot knative-prow-robot added area/test-and-release Test infrastructure, tests or release approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 13, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 13, 2020

Codecov Report

Merging #4309 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4309   +/-   ##
=======================================
  Coverage   80.36%   80.36%           
=======================================
  Files         288      288           
  Lines        7910     7910           
=======================================
  Hits         6357     6357           
  Misses       1172     1172           
  Partials      381      381           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0889429...076f7ec. Read the comment docs.

@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

/retest flakyness not related to these changes. I'm gonna do the changes downstream too

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@slinkydeveloper: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test pull-knative-eventing-build-tests
  • /test pull-knative-eventing-unit-tests
  • /test pull-knative-eventing-integration-tests
  • /test pull-knative-eventing-conformance-tests
  • /test pull-knative-eventing-upgrade-tests
  • /test pull-knative-eventing-go-coverage

Use /test all to run all jobs.

Details

In response to this:

/retest flakyness not related to these changes. I'm gonna do the changes downstream too

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

/retest

@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper slinkydeveloper changed the title Remove transformevents Remove transformevents usages Oct 14, 2020
@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

slinkydeveloper commented Oct 14, 2020

I brought back the image to be less breaky with downstream, but i removed all usages. downstream just needs to remove the image import from hack/tools.go

@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

/retest

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Oct 14, 2020

This is a known flake:

=== CONT  TestChannelChainV1beta1/InMemoryChannel-messaging.knative.dev/v1beta1
    channel_chain_test_helper.go:115: Timeout waiting for at least 2 matches.
        Error: FAIL MATCHING: saw 1/2 matching events.
        Recent events: 
        1 events seen, last 1 events:Validation: valid
        Context Attributes,
          specversion: 1.0
          type: dev.knative.test.event
          source: http://e2e-channelchain-sender.svc/
          id: dummy
          datacontenttype: application/json
        Extensions,
          knativehistory: e2e-channelchain1-kn-channel.test-channel-chain-v1beta1-in-memory-channel-messaging-knaxdmpz.svc.cluster.local; e2e-channelchain2-kn-channel.test-channel-chain-v1beta1-in-memory-channel-messaging-knaxdmpz.svc.cluster.local
        Data,
          {
            "msg": "TestSingleEvent 08674344-f1d8-421b-961c-daf0ed301769"
          }
        
        
        Match errors: 
        
        
        knative.dev/eventing/test/lib/recordevents.(*EventInfoStore).AssertAtLeast
        	/home/prow/go/src/knative.dev/eventing/test/lib/recordevents/event_info_store.go:152
        knative.dev/eventing/test/e2e/helpers.ChannelChainTestHelper.func1
        	/home/prow/go/src/knative.dev/eventing/test/e2e/helpers/channel_chain_test_helper.go:115
        knative.dev/eventing/test/lib.(*ComponentsTestRunner).RunTests.func1
        	/home/prow/go/src/knative.dev/eventing/test/lib/test_runner.go:75
        testing.tRunner

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slinkydeveloper, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Oct 14, 2020

/test pull-knative-eventing-integration-tests

@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

/retest

Redelivery flakyness

@knative-prow-robot knative-prow-robot merged commit 3e7f942 into knative:master Oct 14, 2020
@slinkydeveloper slinkydeveloper deleted the remove_transformevents branch October 14, 2020 14:10
slinkydeveloper added a commit to slinkydeveloper/eventing that referenced this pull request Oct 20, 2020
* Remove transformevents

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Comments

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Let's be less breaky: brought back the image

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

(cherry picked from commit 3e7f942)
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
slinkydeveloper added a commit to slinkydeveloper/eventing that referenced this pull request Oct 20, 2020
* Remove transformevents

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Comments

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Let's be less breaky: brought back the image

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

(cherry picked from commit 3e7f942)
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
knative-prow-robot pushed a commit that referenced this pull request Oct 20, 2020
* Replacing port-forwarding with k8s events in recordevents (#4171)

* WIP Replacing port-forwarding with k8s events in recordevents

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* WIP Events are sent properly from recordevents to k8s events

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Sending the beast in battle

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Update

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Moved resources of recordevents in proper module

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* gofmt

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Another one

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Other stuff

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Copyrights

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Other copyrights

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* boilerplate check

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* boilerplate check

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Other lints checks

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Warn

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Now the linter

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Missing decorator in recordevents

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Simplified the sink definition, just sending events to myself

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Happy linter, happy me

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Correct HTTP server shutdown

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Try fix correlator config

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Just close the server

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Still messing up with the Event correlator options

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* lint check

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

(cherry picked from commit b7a7126)
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Reuse recordevents as transformevents (#4291)

* transformevents done

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* transformevents done

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Test

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Fix copyright

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Did something

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

(cherry picked from commit d5d4f42)
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Using recordevents as sequencestepper (#4313)

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
(cherry picked from commit 656ab81)

* Remove transformevents usages (#4309)

* Remove transformevents

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Comments

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Let's be less breaky: brought back the image

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

(cherry picked from commit 3e7f942)
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Fixes after cherry pick

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Remove sequence stepper usages (#4344)

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

(cherry picked from commit 515f416)
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Remove filterevents usages (#4347)

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
(cherry picked from commit ca85d86)
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

# Conflicts:
#	test/lib/resources/kube.go

* Update

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Not sure why SYSTEM_NAMESPACE doesn't work in 0.17

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Did the same error 2 times

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
slinkydeveloper added a commit to slinkydeveloper/eventing that referenced this pull request Oct 23, 2020
* Remove transformevents

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Comments

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Let's be less breaky: brought back the image

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

(cherry picked from commit 3e7f942)
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
knative-prow-robot pushed a commit that referenced this pull request Oct 23, 2020
* Reuse recordevents as transformevents (#4291)

* transformevents done

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* transformevents done

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Test

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Fix copyright

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Did something

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

(cherry picked from commit d5d4f42)
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Using recordevents as sequencestepper (#4313)

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
(cherry picked from commit 656ab81)

* Remove transformevents usages (#4309)

* Remove transformevents

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Comments

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Let's be less breaky: brought back the image

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

(cherry picked from commit 3e7f942)
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Remove sequence stepper usages (#4344)

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

(cherry picked from commit 515f416)
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Remove filterevents usages (#4347)

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

(cherry picked from commit ca85d86)
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Fix

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants