[release-0.18] Replacing port-forwarding with k8s events in recordevents#4230
Merged
knative-prow-robot merged 3 commits intoOct 9, 2020
Merged
Conversation
* WIP Replacing port-forwarding with k8s events in recordevents Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * WIP Events are sent properly from recordevents to k8s events Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Sending the beast in battle Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Update Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Moved resources of recordevents in proper module Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * gofmt Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Another one Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Other stuff Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Copyrights Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Other copyrights Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * boilerplate check Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * boilerplate check Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Other lints checks Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Warn Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Now the linter Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Missing decorator in recordevents Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Simplified the sink definition, just sending events to myself Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Happy linter, happy me Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Correct HTTP server shutdown Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Try fix correlator config Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Just close the server Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Still messing up with the Event correlator options Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * lint check Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit b7a7126) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
knative-prow-robot
added
size/XXL
Member
|
/lgtm |
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
|
The following jobs failed:
Automatically retrying due to test flakiness... |
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port from #4171
/assign @matzew