Types for v1 duck

[nlopezgi]

Part of #3336

Proposed Changes

• Add types for Add V1 api for duck.* - a prerequisite for doing messaging (will work on messaging afterwards)

[matzew]

Not sure it fixes #3336 - it's part of that ticket

[nlopezgi]

Not sure it fixes #3336 - it's part of that ticket

Thanks for noting, updated comment

[nlopezgi]

This is now ready for review. fyi @matzew @vaikas

[matzew]

@nlopezgi Please run hack/update-codegen.sh

[nlopezgi]

@nlopezgi Please run hack/update-codegen.sh

thanks, running it right now

[nlopezgi]

@nlopezgi Please run hack/update-codegen.sh

Had to rebase as CI still complained after I ran hack/update-codegen.sh. Will ping here once build-tests are passing

[vaikas]

/lgtm
/approve

[nlopezgi]

ugh, ran ./hack/update-deps.sh --upgrade && ./hack/update-codegen.sh and CI is still complaining, I think I might have a tool used by update-codegen stuck in an older version, not sure which one though. Any advice is appreciated.

[nlopezgi]

updated godep on my dev machine, lets see if that fixes the issue.

[nlopezgi]

Still failing on CI, I ran verify-codegen locally and it succeeds, so there has to be some tool that I have in a different version than prow for this to fail. And its not ko or godep, as I just verified those two. Any advice is appreciated.

[vaikas]

Yeah, that's weird as it still is saying this:

/home/prow/go/src/knative.dev/eventing is out of date. Please run hack/update-codegen.sh

Of course, this seems a bit odd?:

./test/../vendor/knative.dev/test-infra/scripts/library.sh: line 534: /go/bin/kntest: Argument list too long

[matzew]

rebase or so meeded? or deps updates?

On Mon 22. Jun 2020 at 18:24, Nicolas Lopez ***@***.***> wrote: Still failing on CI, I ran verify-codegen locally and it succeeds, so there has to be some tool that I have in a different version than prow for this to fail. And its not ko or godep, as I just verified those two. Any advice is appreciated. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3350 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABGPTWE7NHNNCXHUSJZ2TTRX6AUPANCNFSM4OCWYPGQ> .

-- Sent from Gmail Mobile

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/duck/v1/channelable_types.go	Do not exist	87.5%
pkg/apis/duck/v1/delivery_conversion.go	Do not exist	100.0%
pkg/apis/duck/v1/delivery_types.go	Do not exist	92.3%
pkg/apis/duck/v1/subscribable_types.go	Do not exist	100.0%
pkg/apis/duck/v1/subscribable_types_conversion.go	Do not exist	100.0%
pkg/apis/duck/v1beta1/delivery_conversion.go	100.0%	68.8%	-31.2

[vaikas]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlopezgi, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nlopezgi]

Ok, looks like build tests finally passed. Thanks for the advice on how to fix update-deps, I honestly have no idea what is wrong with my setup, but this is now ready.