Skip to content

[WIP] v1 types for eventing.*#3368

Closed
aliok wants to merge 9 commits into
knative:masterfrom
aliok:eventing_types_v1
Closed

[WIP] v1 types for eventing.*#3368
aliok wants to merge 9 commits into
knative:masterfrom
aliok:eventing_types_v1

Conversation

@aliok
Copy link
Copy Markdown
Member

@aliok aliok commented Jun 22, 2020

Ticket: #3337

Proposed Changes

Release Note


Docs

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 22, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 22, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 22, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aliok
To complete the pull request process, please assign tcnghia
You can assign the PR to them by writing /assign @tcnghia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aliok aliok marked this pull request as draft June 22, 2020 12:21
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Jun 22, 2020
@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/eventing/v1/broker_defaults.go Do not exist 100.0%
pkg/apis/eventing/v1/broker_lifecycle.go Do not exist 95.5%
pkg/apis/eventing/v1/broker_types.go Do not exist 66.7%
pkg/apis/eventing/v1/broker_validation.go Do not exist 94.4%
pkg/apis/eventing/v1/eventtype_defaults.go Do not exist 100.0%
pkg/apis/eventing/v1/eventtype_lifecycle.go Do not exist 71.4%
pkg/apis/eventing/v1/eventtype_types.go Do not exist 66.7%
pkg/apis/eventing/v1/eventtype_validation.go Do not exist 92.3%
pkg/apis/eventing/v1/register.go Do not exist 0.0%
pkg/apis/eventing/v1/test_helper.go Do not exist 80.0%
pkg/apis/eventing/v1/trigger_defaults.go Do not exist 100.0%
pkg/apis/eventing/v1/trigger_lifecycle.go Do not exist 51.1%
pkg/apis/eventing/v1/trigger_types.go Do not exist 100.0%
pkg/apis/eventing/v1/trigger_validation.go Do not exist 96.2%

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@aliok: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-eventing-go-coverage 5def5bd link /test pull-knative-eventing-go-coverage

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aliok aliok force-pushed the eventing_types_v1 branch from 5def5bd to fc0008b Compare June 22, 2020 14:25
@googlebot
Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Jun 22, 2020
@matzew matzew mentioned this pull request Jun 23, 2020
@aliok
Copy link
Copy Markdown
Member Author

aliok commented Jun 23, 2020

/close
Closing in favor of #3372

@aliok aliok closed this Jun 23, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

@aliok: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2020
@aliok aliok deleted the eventing_types_v1 branch April 28, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test-and-release Test infrastructure, tests or release cla: no Indicates the PR's author has not signed the CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants