Skip to content

Updating to k8s 1.11.#344

Merged
knative-prow-robot merged 9 commits into
knative:masterfrom
n3wscott:update-dep-kube-pkg
Aug 14, 2018
Merged

Updating to k8s 1.11.#344
knative-prow-robot merged 9 commits into
knative:masterfrom
n3wscott:update-dep-kube-pkg

Conversation

@n3wscott
Copy link
Copy Markdown
Contributor

@n3wscott n3wscott commented Aug 13, 2018 •
edited
Loading

knative serving and pkg have moved on to k8s 1.11 clients. If we would like to get new pkg features, we need to move on too.

I updated controller-runtime to k8s 1.11 and will use my fork as a dep for now until the kubebuilder team is able to update both kubebuilder and controller-runtime.

See kubernetes-sigs/controller-runtime#108

@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 13, 2018
@n3wscott
Copy link
Copy Markdown
Contributor Author

n3wscott commented Aug 13, 2018

/assign @mattmoor

Matt did similar work for pkg and serving.

@n3wscott
Copy link
Copy Markdown
Contributor Author

n3wscott commented Aug 13, 2018

Depends on kubernetes-sigs/controller-runtime#108

@n3wscott n3wscott force-pushed the update-dep-kube-pkg branch from 8fc4695 to 54e6dd5 Compare August 13, 2018 16:34
@n3wscott
Copy link
Copy Markdown
Contributor Author

n3wscott commented Aug 13, 2018

I updated controller-runtime to k8s 1.11 and will use my fork as a dep for now until the kubebuilder team is able to update both kubebuilder and controller-runtime.

@grantr
Copy link
Copy Markdown
Contributor

grantr commented Aug 13, 2018

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2018
@n3wscott
Copy link
Copy Markdown
Contributor Author

n3wscott commented Aug 13, 2018

The e2e test seems to be blocked by #345

@n3wscott
Copy link
Copy Markdown
Contributor Author

n3wscott commented Aug 13, 2018

e2e test is not blocked, it just flaked on istio. It gets just a warn from #345

/test pull-knative-eventing-integration-tests

@n3wscott
Copy link
Copy Markdown
Contributor Author

n3wscott commented Aug 13, 2018

/test pull-knative-eventing-integration-tests

@n3wscott
Copy link
Copy Markdown
Contributor Author

n3wscott commented Aug 13, 2018

closes #335

@n3wscott n3wscott force-pushed the update-dep-kube-pkg branch from 550918b to b2a8d38 Compare August 13, 2018 20:10
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2018
@n3wscott
Copy link
Copy Markdown
Contributor Author

n3wscott commented Aug 13, 2018

I found a real issue in my patch of moving controller-runtime to k8s 1.11. I fixed this on my fork, pulling that change in now.

@n3wscott n3wscott mentioned this pull request Aug 13, 2018
Closed
evankanderson
evankanderson reviewed Aug 13, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2018
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Aug 13, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2018
@knative-prow-robot knative-prow-robot merged commit f8e9563 into knative:master Aug 14, 2018
n3wscott added a commit to n3wscott/eventing that referenced this pull request Aug 14, 2018
@n3wscott
Updating to k8s 1.11. (knative#344)
4f4487b 
* Updating to k8s 1.11.

* Forgot the new vendored code.

* Update controller-runtime to k8s 1.11.

* Ran update-codegen.

* Update to Resource.Resource. There was an issue fixed in controller-runtime fork.

* Action needs a namespace now.

* should not have to set this namespace, revert.

* Lost the namespace on the dynamic client for flows, adding back.

* Looks like it was not a set namespace method, but returns a new obj. Really use it this time.
@grantr grantr mentioned this pull request Aug 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson evankanderson left review comments

@ultrasaurus ultrasaurus Awaiting requested review from ultrasaurus

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@grantr grantr

@mattmoor mattmoor

@evankanderson evankanderson

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@n3wscott @grantr @knative-prow-robot @evankanderson @mattmoor