Skip to content

Use knative/pkg/webhook to host the webhook controller.#350

Closed
n3wscott wants to merge 9 commits into
knative:masterfrom
n3wscott:move-to-webhookv2
Closed

Use knative/pkg/webhook to host the webhook controller.#350
n3wscott wants to merge 9 commits into
knative:masterfrom
n3wscott:move-to-webhookv2

Conversation

@n3wscott
Copy link
Copy Markdown
Contributor

Moves to use the shared controller in /pkg.
Removes all eventing/pkg/webhook/ code because it is no longer needed 🎉

@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 13, 2018
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: n3wscott
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ultrasaurus

If they are not already assigned, you can assign the PR to them by writing /assign @ultrasaurus in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@n3wscott n3wscott closed this Aug 13, 2018
@n3wscott
Copy link
Copy Markdown
Contributor Author

This will depend on #344 being merged. Will reopen when that has landed.

@n3wscott n3wscott reopened this Aug 14, 2018
@n3wscott n3wscott closed this Aug 14, 2018
@knative-prow-robot
Copy link
Copy Markdown
Contributor

@n3wscott: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-eventing-go-coverage 3401405 link /test pull-knative-eventing-go-coverage
pull-knative-eventing-build-tests 3401405 link /test pull-knative-eventing-build-tests
pull-knative-eventing-unit-tests 3401405 link /test pull-knative-eventing-unit-tests
pull-knative-eventing-integration-tests 3401405 link /test pull-knative-eventing-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants