Skip to content

Make SubscribableStatus implement apis.Convertible#3471

Merged
knative-prow-robot merged 2 commits into
knative:masterfrom
aliok:duck_conv_01_SubscribableStatus
Jul 3, 2020
Merged

Make SubscribableStatus implement apis.Convertible#3471
knative-prow-robot merged 2 commits into
knative:masterfrom
aliok:duck_conv_01_SubscribableStatus

Conversation

@aliok
Copy link
Copy Markdown
Member

@aliok aliok commented Jul 3, 2020 •
edited
Loading

Part of #3474

Proposed Changes

  • Make SubscribableStatus implement apis.Convertible

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 3, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 3, 2020
@aliok
Copy link
Copy Markdown
Member Author

aliok commented Jul 3, 2020

/unassign aslom yolocs
/assign @nlopezgi @lionelvillard

@aliok aliok force-pushed the duck_conv_01_SubscribableStatus branch from 5f7939f to b6c3c78 Compare July 3, 2020 08:03
@aliok
Copy link
Copy Markdown
Member Author

aliok commented Jul 3, 2020

/retest

1 similar comment
@aliok
Copy link
Copy Markdown
Member Author

aliok commented Jul 3, 2020

/retest

This was referenced Jul 3, 2020
Merged
Merged
@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Jul 3, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/e2e.TestBrokerChannelFlowTriggerV1BrokerV1
test/e2e.TestSequenceV1
test/e2e.TestSequenceV1/Channel-messaging.knative.dev/v1
test/e2e.TestBrokerChannelFlowTriggerV1BrokerV1/Channel-messaging.knative.dev/v1

@aliok aliok force-pushed the duck_conv_01_SubscribableStatus branch from b6c3c78 to 5f9e484 Compare July 3, 2020 09:42
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Jul 3, 2020

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/duck/v1alpha1/subscribable_types_conversion.go 97.8% 98.0% 0.2
pkg/apis/duck/v1beta1/subscribable_types_conversion.go 95.7% 96.2% 0.4

@aliok aliok mentioned this pull request Jul 3, 2020
Merged
@nlopezgi
Copy link
Copy Markdown
Contributor

nlopezgi commented Jul 3, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2020
@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Jul 3, 2020

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 3, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2020
@knative-prow-robot knative-prow-robot merged commit 5e065fb into knative:master Jul 3, 2020
@aliok aliok deleted the duck_conv_01_SubscribableStatus branch July 6, 2020 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aslom aslom Awaiting requested review from aslom

@yolocs yolocs Awaiting requested review from yolocs

Assignees

@nlopezgi nlopezgi

@lionelvillard lionelvillard

@vaikas vaikas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@aliok @knative-test-reporter-robot @knative-metrics-robot @nlopezgi @vaikas @knative-prow-robot @googlebot @lionelvillard