Make SubscriberStatus implement apis.Convertible#3475
Merged
knative-prow-robot merged 1 commit intoJul 6, 2020
Conversation
knative-prow-robot
added
do-not-merge/work-in-progress
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
|
The following jobs failed:
Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests: |
knative-prow-robot
added
the
needs-rebase
aliok
force-pushed
the
duck_conv_04_SubscriberStatus
branch
from
670229b to
04b350b
Compare
knative-prow-robot
added
size/L
aliok
force-pushed
the
duck_conv_04_SubscriberStatus
branch
from
04b350b to
544b08b
Compare
knative-prow-robot
added
size/M
aliok
commented
Jul 6, 2020
| } | ||
|
|
||
| func TestSubscribableTypeSpecStatusConversionBadType(t *testing.T) { | ||
| func TestSubscribableTypeSpecConversionBadType(t *testing.T) { |
Member
Author
There was a problem hiding this comment.
Fixed some wrong function name while at it
aliok
commented
Jul 6, 2020
| } | ||
|
|
||
| func TestSubscriberSpecStatusConversionBadType(t *testing.T) { | ||
| func TestSubscriberSpecConversionBadType(t *testing.T) { |
Member
Author
There was a problem hiding this comment.
Fixed some wrong function name while at it
aliok
changed the title
knative-prow-robot
removed
the
do-not-merge/work-in-progress
|
The following is the coverage report on the affected files.
|
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3474
Same story with #3471, but for
SubscriberStatus