Skip to content

[WIP] bump webhook resources since we're seeing EOFs#3758

Closed
dprotaso wants to merge 2 commits into
knative:masterfrom
dprotaso:bump-webhook
Closed

[WIP] bump webhook resources since we're seeing EOFs#3758
dprotaso wants to merge 2 commits into
knative:masterfrom
dprotaso:bump-webhook

Conversation

@dprotaso
Copy link
Copy Markdown
Member

@dprotaso dprotaso commented Jul 30, 2020 •
edited
Loading

Proposed Changes

  • Bump webhook resources like serving did prior to chaos testing

Note: this may not be the solution but in serving when we saw the webhook being slammed probes failed and the container was killed

Related:
knative/serving#8048
knative/pkg#1509

Release Note

NONE

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 30, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 30, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 30, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dprotaso
To complete the pull request process, please assign n3wscott
You can assign the PR to them by writing /assign @n3wscott in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Jul 30, 2020

/assign @n3wscott

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Jul 30, 2020

/retest

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Jul 30, 2020

interesting -
creation.go:180: Failed to create subscription "e2e-eventtransformation-subs21": conversion webhook for messaging.knative.dev/v1beta1, Kind=Subscription failed: Post https://eventing-webhook.knative-eventing-xsyrti7kz3.svc:443/resource-conversion?timeout=30s: EOF

I'll poke at this more tomorrow

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Jul 31, 2020

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2020
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 31, 2020
@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Jul 31, 2020

/retest pull-knative-eventing-integration-tests

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 31, 2020

@dprotaso: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test pull-knative-eventing-build-tests
  • /test pull-knative-eventing-unit-tests
  • /test pull-knative-eventing-integration-tests
  • /test pull-knative-eventing-conformance-tests
  • /test pull-knative-eventing-upgrade-tests
  • /test pull-knative-eventing-go-coverage

Use /test all to run all jobs.

Details

In response to this:

/retest pull-knative-eventing-integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Jul 31, 2020

/test pull-knative-eventing-integration-tests

@dprotaso dprotaso changed the title bump webhook resources since we're seeing EOFs [WIP] bump webhook resources since we're seeing EOFs Jul 31, 2020
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2020
@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Jul 31, 2020

/test pull-knative-eventing-integration-tests

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Aug 1, 2020

/test pull-knative-eventing-integration-tests

where are the failures when you look for them

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Aug 1, 2020

/test pull-knative-eventing-integration-tests

5 similar comments
@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Aug 1, 2020

/test pull-knative-eventing-integration-tests

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Aug 1, 2020

/test pull-knative-eventing-integration-tests

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Aug 1, 2020

/test pull-knative-eventing-integration-tests

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Aug 1, 2020

/test pull-knative-eventing-integration-tests

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Aug 1, 2020

/test pull-knative-eventing-integration-tests

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Aug 1, 2020

/test pull-knative-eventing-integration-tests

2 similar comments
@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Aug 1, 2020

/test pull-knative-eventing-integration-tests

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Aug 2, 2020

/test pull-knative-eventing-integration-tests

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 2, 2020
@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Aug 2, 2020 •
edited
Loading

adding original commit back - maybe that'll trigger it again consistently (again)

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Aug 2, 2020

/test pull-knative-eventing-integration-tests

5 similar comments
@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Aug 2, 2020

/test pull-knative-eventing-integration-tests

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Aug 2, 2020

/test pull-knative-eventing-integration-tests

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Aug 3, 2020

/test pull-knative-eventing-integration-tests

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Aug 3, 2020

/test pull-knative-eventing-integration-tests

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Aug 3, 2020

/test pull-knative-eventing-integration-tests

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Aug 3, 2020

@dprotaso: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-eventing-upgrade-tests 9b5309a link /test pull-knative-eventing-upgrade-tests
pull-knative-eventing-build-tests 9b5309a link /test pull-knative-eventing-build-tests
pull-knative-eventing-integration-tests 9b5309a link /test pull-knative-eventing-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Aug 3, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/e2e.TestChannelNamespaceDefaulter
test/e2e.TestChannelNamespaceDefaulter/Channel-messaging.knative.dev/v1

@dprotaso dprotaso mentioned this pull request Aug 4, 2020
Closed
@dprotaso dprotaso closed this Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Harwayne Harwayne Awaiting requested review from Harwayne

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@n3wscott n3wscott

Labels

cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dprotaso @knative-prow-robot @knative-test-reporter-robot @googlebot @n3wscott