Skip to content

Increase webhook resources & skip TestUpdate to reduce test flakes#8048

Merged
knative-prow-robot merged 3 commits into
knative:masterfrom
tcnghia:increase-webhook-resources
May 23, 2020
Merged

Increase webhook resources & skip TestUpdate to reduce test flakes#8048
knative-prow-robot merged 3 commits into
knative:masterfrom
tcnghia:increase-webhook-resources

Conversation

@tcnghia
Copy link
Copy Markdown
Contributor

@tcnghia tcnghia commented May 23, 2020 •
edited
Loading

Fixes #

Proposed Changes

  • Increase webhook resources to attempt to reduce webhook timeout test flakes
  • Skip flaky TestUpdate. We don't want to just do t.Skip() since the test may still be useful for net-* repositories. I opened TestUpdate is very flaky, needs investigation #8032 to track the work of fixing this test.

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 23, 2020
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 23, 2020
knative-prow-robot
knative-prow-robot reviewed May 23, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tcnghia: 0 warnings.

Details

In response to this:

Fixes #

Proposed Changes

  • Increase webhook resources to attempt to reduce test flakes
  • Also skip flaky test TestUpdate (tracked now in #8032, and also tested as part of net-*'s integration tests)

Release Note

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label May 23, 2020
@tcnghia tcnghia changed the title Increase webhook resources to attempt to reduce test flakes Increase webhook resources to attempt to reduce webhook timeout test flakes May 23, 2020
@tcnghia tcnghia force-pushed the increase-webhook-resources branch from a3d08ab to d30b3a3 Compare May 23, 2020 01:49
@tcnghia tcnghia force-pushed the increase-webhook-resources branch from d30b3a3 to 8a1ea7c Compare May 23, 2020 01:53
vagababov
vagababov reviewed May 23, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2020
@tcnghia
Copy link
Copy Markdown
Contributor Author

tcnghia commented May 23, 2020

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2020
@tcnghia
Copy link
Copy Markdown
Contributor Author

tcnghia commented May 23, 2020

/test pull-knative-serving-integration-tests

@tcnghia
Copy link
Copy Markdown
Contributor Author

tcnghia commented May 23, 2020

(all previous 3 runs were failing TestUpdate)

@tcnghia
Copy link
Copy Markdown
Contributor Author

tcnghia commented May 23, 2020

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2020
@tcnghia
Copy link
Copy Markdown
Contributor Author

tcnghia commented May 23, 2020

/test pull-knative-serving-integration-tests

@knative-prow-robot knative-prow-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented May 23, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2020
@tcnghia tcnghia changed the title Increase webhook resources to attempt to reduce webhook timeout test flakes Increase webhook resources & skip TestUpdate to reduce test flakes May 23, 2020
vagababov
vagababov reviewed May 23, 2020
View reviewed changes
Comment thread test/e2e-tests.sh Outdated
@tcnghia tcnghia force-pushed the increase-webhook-resources branch from 0263e4f to 465a6e3 Compare May 23, 2020 06:02
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2020
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2020
@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented May 23, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-integration-tests pull-knative-serving-integration-tests
pull-knative-serving-integration-tests		 2/3

Automatically retrying due to test flakiness...
/test pull-knative-serving-integration-tests

@vagababov
Copy link
Copy Markdown
Contributor

vagababov commented May 23, 2020

/lgtm
/hold
let's see how they pass :)

@knative-prow-robot knative-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels May 23, 2020
@tcnghia
Copy link
Copy Markdown
Contributor Author

tcnghia commented May 23, 2020

looks like passing
/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2020
@knative-prow-robot knative-prow-robot merged commit ed4d688 into knative:master May 23, 2020
This was referenced Jul 30, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@mattmoor mattmoor Awaiting requested review from mattmoor

+1 more reviewer

@vagababov vagababov vagababov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@vagababov vagababov

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tcnghia @knative-prow-robot @knative-test-reporter-robot @vagababov @googlebot