Skip to content

Increase webhook resources & skip TestUpdate to reduce test flakes #8048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 3 commits into from
May 23, 2020
Merged

Increase webhook resources & skip TestUpdate to reduce test flakes #8048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a1ea7c
Increase webhook resources.
May 23, 2020
465a6e3
Skip the TestUpdate.
May 23, 2020
dc98784
Merge branch 'master' into increase-webhook-resources
May 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions config/core/deployments/webhook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ spec:

resources:
requests:
cpu: 20m
memory: 20Mi
cpu: 100m
memory: 100Mi
limits:
cpu: 200m
memory: 200Mi
cpu: 500m
memory: 500Mi

env:
- name: SYSTEM_NAMESPACE
Expand Down
8 changes: 7 additions & 1 deletion test/e2e-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,17 @@ add_trap "kubectl -n ${SYSTEM_NAMESPACE} patch configmap/config-autoscaler --typ
# Run conformance and e2e tests.

go_test_e2e -timeout=30m \
$(go list ./test/conformance/... | grep -v certificate) \
$(go list ./test/conformance/... | grep -v 'certificate\|ingress' ) \
./test/e2e ./test/e2e/hpa \
${parallelism} \
"--resolvabledomain=$(use_resolvable_domain)" "${use_https}" "$(ingress_class)" || failed=1

# We run KIngress conformance ingress separately, to make it easier to skip some tests.
go_test_e2e -timeout=20m ./test/conformance/ingress ${parallelism} \
`# Skip TestUpdate due to excessive flaking https://github.com/knative/serving/issues/8032` \
-run="Test[^U]" \
"--resolvabledomain=$(use_resolvable_domain)" "${use_https}" "$(ingress_class)" || failed=1

if (( HTTPS )); then
kubectl delete -f ${TMP_DIR}/test/config/autotls/certmanager/caissuer/ --ignore-not-found
turn_off_auto_tls
Expand Down