Add grantr to list of approvers#387
Conversation
|
/lgtm @grantr has provided me with great feedback through several PRs and I value his reviews. |
|
I'm going to leave this for a day or so in case others have comments, but Grant has done substantial cleanup and testing work in addition to the reviews mentioned above. |
|
+1 for adding @grantr! his feedback is always insightful and reveals a strong background in messaging systems |
|
+1 |
|
/assign @vaikas-google |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantr, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Followup: @n3wscott pointed out that my queries for reviewed PRs included PRs I authored, which was unintentional. Fortunately I still met the requirements without them. 😁 Use the I updated the queries above (but not the counts) since they might be used as examples. |
From ROLES.md:
Total project lifetime: 182 days (2018-03-12 to 2018-08-21)
50% of project lifetime: 91 days
Earliest review: 2018-05-29, 84 days ago
https://github.com/knative/eventing/pulls?utf8=%E2%9C%93&q=is%3Apr+reviewed-by%3Agrantr+sort%3Acreated-asc
Reviewed 23 L, XL, or XXL PRs
https://github.com/knative/eventing/pulls?utf8=%E2%9C%93&q=is%3Apr+-author%3Agrantr+reviewed-by%3Agrantr+label%3Asize%2FL
https://github.com/knative/eventing/pulls?utf8=%E2%9C%93&q=is%3Apr+-author%3Agrantr+reviewed-by%3Agrantr+label%3Asize%2FXL
https://github.com/knative/eventing/pulls?utf8=%E2%9C%93&q=is%3Apr+-author%3Agrantr+reviewed-by%3Agrantr+label%3Asize%2FXXL
10 substantial examples:
Reviewed or merged 44 PRs
https://github.com/knative/eventing/pulls?utf8=%E2%9C%93&q=is%3Apr+reviewed-by%3Agrantr
Current eventing lead is @vaikas-google.
/cc @evankanderson @mattmoor @vaikas-google