Skip to content

Add grantr to list of approvers#387

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
grantr:grantr-approver
Aug 27, 2018
Merged

Add grantr to list of approvers#387
knative-prow-robot merged 1 commit into
knative:masterfrom
grantr:grantr-approver

Conversation

@grantr
Copy link
Copy Markdown
Contributor

@grantr grantr commented Aug 21, 2018

From ROLES.md:

Reviewer of the codebase for at least 3 months or 50% of project lifetime, whichever is shorter

Total project lifetime: 182 days (2018-03-12 to 2018-08-21)
50% of project lifetime: 91 days

Earliest review: 2018-05-29, 84 days ago
https://github.com/knative/eventing/pulls?utf8=%E2%9C%93&q=is%3Apr+reviewed-by%3Agrantr+sort%3Acreated-asc

Primary reviewer for at least 10 substantial PRs to the codebase

Reviewed 23 L, XL, or XXL PRs
https://github.com/knative/eventing/pulls?utf8=%E2%9C%93&q=is%3Apr+-author%3Agrantr+reviewed-by%3Agrantr+label%3Asize%2FL
https://github.com/knative/eventing/pulls?utf8=%E2%9C%93&q=is%3Apr+-author%3Agrantr+reviewed-by%3Agrantr+label%3Asize%2FXL
https://github.com/knative/eventing/pulls?utf8=%E2%9C%93&q=is%3Apr+-author%3Agrantr+reviewed-by%3Agrantr+label%3Asize%2FXXL

10 substantial examples:

  1. Rewriting the GitHub Event Sample README #343 (review)
  2. Adding docs/spec shell. #147 (review)
  3. GitHub Receive adapter as a serving Service. #276 (review)
  4. [WIP] Convert Flow controller to provider/reconcile model #287 (review)
  5. Use knative/pkg/webhooks #352 (review)
  6. move eventsources out of proc to containers #62 (review)
  7. Refine bus monitor #88 (review)
  8. Adding validatable to bus types. #321 (review)
  9. Flow resource creation comes from the resource dir. #316 (review)
  10. Add configmap for flow controller #324 (review)

Reviewed or merged at least 30 PRs to the codebase

Reviewed or merged 44 PRs
https://github.com/knative/eventing/pulls?utf8=%E2%9C%93&q=is%3Apr+reviewed-by%3Agrantr

Nominated by an area lead with no objections from other leads

Current eventing lead is @vaikas-google.

/cc @evankanderson @mattmoor @vaikas-google

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 21, 2018
@n3wscott
Copy link
Copy Markdown
Contributor

/lgtm

@grantr has provided me with great feedback through several PRs and I value his reviews.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2018
@evankanderson
Copy link
Copy Markdown
Member

I'm going to leave this for a day or so in case others have comments, but Grant has done substantial cleanup and testing work in addition to the reviews mentioned above.

@dprotaso
Copy link
Copy Markdown
Member

I think @grantr shouldn't be on probation anymore 😛

@markfisher
Copy link
Copy Markdown
Contributor

+1 for adding @grantr! his feedback is always insightful and reveals a strong background in messaging systems

@mattmoor
Copy link
Copy Markdown
Member

+1

@evankanderson
Copy link
Copy Markdown
Member

/assign @vaikas-google
/assign @evankanderson

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Aug 27, 2018

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2018
@knative-prow-robot knative-prow-robot merged commit ff7136c into knative:master Aug 27, 2018
@grantr grantr deleted the grantr-approver branch September 25, 2018 21:59
@grantr
Copy link
Copy Markdown
Contributor Author

grantr commented Sep 25, 2018

Followup: @n3wscott pointed out that my queries for reviewed PRs included PRs I authored, which was unintentional. Fortunately I still met the requirements without them. 😁

Use the -author:<yourusername> qualifier to exclude your own PRs:

https://github.com/knative/eventing/pulls?utf8=%E2%9C%93&q=is%3Apr+-author%3Agrantr+reviewed-by%3Agrantr+label%3Asize%2FL

I updated the queries above (but not the counts) since they might be used as examples.

matzew pushed a commit to matzew/eventing that referenced this pull request Apr 11, 2019
matzew pushed a commit to matzew/eventing that referenced this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants