Rename pullrequest to dev.knative.github.pullrequest in Github sample#395
Closed
tanzeeb wants to merge 1 commit into
Closed
Rename pullrequest to dev.knative.github.pullrequest in Github sample#395tanzeeb wants to merge 1 commit into
tanzeeb wants to merge 1 commit into
Conversation
…request in github sample
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tanzeeb If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Author
Member
|
I believe that @n3wscott is in the process of moving this sample to
`knative/docs`, possibly http://github.com/knative/docs/pull/339
…On Fri, Aug 24, 2018 at 2:45 PM Tanzeeb Khalili ***@***.***> wrote:
/assign @inlined <https://github.com/inlined> @mattmoor
<https://github.com/mattmoor>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#395 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHlyN3U-jRVzaJijEWQtiUjYTdj7fECjks5uUHQCgaJpZM4WMCHz>
.
--
Evan Anderson <argent@google.com>
|
Author
|
Thanks for the heads up @evankanderson. Looks like the other PR has the changes addressed here, closing. |
mgencur
pushed a commit
to mgencur/eventing
that referenced
this pull request
Oct 25, 2023
….... (knative#395) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of #340 , the
pullrequestevent is nowdev.knative.github.pullrequest. This PR updates the github sample to reflect the change.