Skip to content

Rename pullrequest to dev.knative.github.pullrequest in Github sample#395

Closed
tanzeeb wants to merge 1 commit into
knative:masterfrom
tanzeeb:fix-github-sample
Closed

Rename pullrequest to dev.knative.github.pullrequest in Github sample#395
tanzeeb wants to merge 1 commit into
knative:masterfrom
tanzeeb:fix-github-sample

Conversation

@tanzeeb
Copy link
Copy Markdown

@tanzeeb tanzeeb commented Aug 24, 2018

As of #340 , the pullrequest event is now dev.knative.github.pullrequest. This PR updates the github sample to reflect the change.

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tanzeeb
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: inlined

If they are not already assigned, you can assign the PR to them by writing /assign @inlined in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 24, 2018
@tanzeeb
Copy link
Copy Markdown
Author

tanzeeb commented Aug 24, 2018

/assign @inlined @mattmoor

@evankanderson
Copy link
Copy Markdown
Member

evankanderson commented Aug 24, 2018 via email

@tanzeeb
Copy link
Copy Markdown
Author

tanzeeb commented Aug 27, 2018

Thanks for the heads up @evankanderson. Looks like the other PR has the changes addressed here, closing.

@tanzeeb tanzeeb closed this Aug 27, 2018
mgencur pushed a commit to mgencur/eventing that referenced this pull request Oct 25, 2023
….... (knative#395)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants