Skip to content

Rename pullrequest to dev.knative.github.pullrequest in Github sample #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tanzeeb wants to merge 1 commit into from
Closed

Rename pullrequest to dev.knative.github.pullrequest in Github sample #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sample/github/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ ko apply -f config/buses/stub
ko apply -f pkg/sources/github/
```

5. Check that the GitHub is now showing up as an event source and there's an event type for *pullrequests*
5. Check that the GitHub is now showing up as an event source and there's an event type for *dev.knative.github.pullrequest*

```shell
kubectl get eventsources
Expand Down Expand Up @@ -78,7 +78,7 @@ In response to a pull request event, the _legit_ Service will add `(looks pretty
Deploy the _legit_ service via:

```shell
ko apply sample/github/legit-service.yaml
ko apply -f sample/github/legit-service.yaml
```

Once deployed, you can inspect the created resources with `kubectl` commands:
Expand Down
2 changes: 1 addition & 1 deletion sample/github/flow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ metadata:
spec:
serviceAccountName: feed-sa
trigger:
eventType: pullrequest
eventType: dev.knative.github.pullrequest
resource: <org>/<repo> # TODO: Fill this out
service: github
parameters:
Expand Down