Propagate the entire delivery spec to the Channel#4042
Merged
knative-prow-robot merged 2 commits intoSep 14, 2020
Conversation
The subscription reconciler didn't propagate the entire `deliverySpec` to the channel, only the `deadLetterSink` was propagated. Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
knative-prow-robot
added
the
size/L
mattmoor
reviewed
Sep 14, 2020
pierDipi
force-pushed
the
propagate-delivery-spec
branch
from
0c76342 to
725ead4
Compare
Member
Author
Contributor
|
/assign |
Member
Author
/retest |
Member
Author
|
I'll backport it once it's approved. |
Contributor
slinkydeveloper
left a comment
slinkydeveloper
left a comment
There was a problem hiding this comment.
little nit but lgtm
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi, slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
The following is the coverage report on the affected files.
|
pierDipi
added a commit
to pierDipi/eventing
that referenced
this pull request
Sep 14, 2020
* Propagate the entire delivery spec to the Channel The subscription reconciler didn't propagate the entire `deliverySpec` to the channel, only the `deadLetterSink` was propagated. Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> * Apply suggestion Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
knative-prow-robot
pushed a commit
that referenced
this pull request
Sep 14, 2020
* Propagate the entire delivery spec to the Channel The subscription reconciler didn't propagate the entire `deliverySpec` to the channel, only the `deadLetterSink` was propagated. Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> * Apply suggestion Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The subscription reconciler didn't propagate the entire
deliverySpecto the channel, only the
deadLetterSinkwas propagated.Proposed Changes
Release Note