[release-0.17] Propagate the entire delivery spec to the Channel (#4042)

[pierDipi]

The subscription reconciler didn't propagate the entire deliverySpec
to the channel, only the deadLetterSink was propagated.

Signed-off-by: Pierangelo Di Pilato pierangelodipilato@gmail.com

Proposed Changes

• Propagate the entire delivery spec to the Channel (Propagate the entire delivery spec to the Channel #4042)

Release Note

- 🐛 Fix bug
The subscription reconciler correctly propagates delivery configurations to the channel (`retry`, `backoffDelay`, `backoffPolicy`).

[pierDipi]

/cc @slinkydeveloper @matzew

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/subscription/subscription.go	76.2%	82.7%	6.5

[matzew]

/lgtm

[aliok]

/lgtm
/approve

I think the reason for the missing propagation is because of the API shape change that happened. Probably things were forgotten.

Bad thing is, no tests caught this :(

Thanks for the fix

[matzew]

Bad thing is, no tests caught this :(

how about we add one more test ? 😄

[knative-test-reporter-robot]

The following jobs failed:

Test name	Triggers	Retries
pull-knative-eventing-integration-tests		0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/e2e.TestBrokerChannelFlowTriggerV1BrokerV1/Channel-messaging.knative.dev/v1beta1
test/e2e.TestBrokerChannelFlowTriggerV1BrokerV1
.Test

[pierDipi]

    broker_channel_flow_helper.go:157: Failed to get the url for the channel "e2e-brokerchannel-channel": addressable does not have an Address: &{TypeMeta:{Kind:Channel APIVersion:messaging.knative.dev/v1beta1} ObjectMeta:{Name:e2e-brokerchannel-channel GenerateName: Namespace:test-broker-channel-flow-trigger-v1-broker-v1-channel-messgspfz SelfLink:/apis/messaging.knative.dev/v1beta1/namespaces/test-broker-channel-flow-trigger-v1-broker-v1-channel-messgspfz/channels/e2e-brokerchannel-channel UID:b2ac6588-f1a4-4e18-9730-49d20479f153 ResourceVersion:43759 Generation:1 CreationTimestamp:2020-09-14 12:36:47 +0000 UTC DeletionTimestamp:<nil> DeletionGracePeriodSeconds:<nil> Labels:map[] Annotations:map[messaging.knative.dev/creator:prow-job@knative-tests.iam.gserviceaccount.com messaging.knative.dev/lastModifier:prow-job@knative-tests.iam.gserviceaccount.com messaging.knative.dev/subscribable:v1beta1] OwnerReferences:[] Finalizers:[] ClusterName: ManagedFields:[]} Status:{Address:<nil>}}
        knative.dev/eventing/test/lib.(*Client).GetAddressableURI

it's a known issue: #3686

[pierDipi]

/retest

[slinkydeveloper]

/lgtm
/approve

Thanks @pierDipi for this backport!

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, pierDipi, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [slinkydeveloper]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment