Skip to content

ContainerSource stored version v1 and migration tool#4657

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
pierDipi:KNATIVE-4325
Jan 7, 2021
Merged

ContainerSource stored version v1 and migration tool#4657
knative-prow-robot merged 1 commit into
knative:masterfrom
pierDipi:KNATIVE-4325

Conversation

@pierDipi
Copy link
Copy Markdown
Member

@pierDipi pierDipi commented Dec 15, 2020

Fixes #4325

Proposed Changes

  • ContainerSource stored version v1
  • Add migration tool

Release Note

Action Required: You need to run the storage migration tool after the upgrade to migrate from v1beta1 to v1 `containersources.sources.knative.dev` resources.

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 15, 2020
@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 15, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Dec 15, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Dec 15, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2020
@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Dec 15, 2020

This is based on #4655.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 15, 2020 •
edited
Loading

Codecov Report

Merging #4657 (fed94ac) into master (653febd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4657   +/-   ##
=======================================
  Coverage   81.07%   81.07%           
=======================================
  Files         291      291           
  Lines        8216     8216           
=======================================
  Hits         6661     6661           
  Misses       1154     1154           
  Partials      401      401

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 653febd...90a203b. Read the comment docs.

@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Dec 15, 2020

Flaky #4637
/retest

@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 6, 2021
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 6, 2021
@pierDipi
ContainerSource stored version v1 and migration tool
90a203b 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Jan 6, 2021

/cc @lionelvillard @zhongduo

@pierDipi pierDipi changed the title [WIP] ContainerSource stored version v1 and migration tool ContainerSource stored version v1 and migration tool Jan 6, 2021
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 6, 2021
zhongduo
zhongduo reviewed Jan 7, 2021
View reviewed changes
Comment thread config/post-install/storage-version-migrator.yaml
image: ko://knative.dev/eventing/vendor/knative.dev/pkg/apiextensions/storageversion/cmd/migrate
args:
- "apiserversources.sources.knative.dev"
- "containersources.sources.knative.dev"
Copy link
Copy Markdown
Contributor

@zhongduo zhongduo Jan 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About your attention in the PR, with this post install job, when using the operator this version migration will work, right?

Copy link
Copy Markdown
Contributor

@lionelvillard lionelvillard Jan 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.

/cc @houshengbo

@lionelvillard
Copy link
Copy Markdown
Contributor

lionelvillard commented Jan 7, 2021

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2021
@eclipselu
Copy link
Copy Markdown
Contributor

eclipselu commented Jan 7, 2021

/lgtm

@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Jan 7, 2021

EOF errors and gotestsum bug,

Error: Could not update trigger trigger-no-broker: conversion webhook for eventing.knative.dev/v1beta1, Kind=Trigger failed: Post https://eventing-webhook.knative-eventing-2xrix7ra2t.svc:443/resource-conversion?timeout=30s: EOF

test/upgrade TestEventingUpgrades/PostDowngradeTests (unknown)

/retest

@knative-prow-robot knative-prow-robot merged commit 14a9fbb into knative:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liu-cong liu-cong Awaiting requested review from liu-cong

@steuhs steuhs Awaiting requested review from steuhs

@yt3liu yt3liu Awaiting requested review from yt3liu

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@houshengbo houshengbo Awaiting requested review from houshengbo

1 more reviewer

@zhongduo zhongduo zhongduo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@eclipselu eclipselu

@lionelvillard lionelvillard

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make v1 the storage version of ContainerSource

5 participants

@pierDipi @knative-prow-robot @lionelvillard @eclipselu @zhongduo