Skip to content

ContainerSource stored version v1 and migration tool #4657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 1 commit into from
Jan 7, 2021
Merged

ContainerSource stored version v1 and migration tool #4657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/core/resources/containersource.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,15 +404,15 @@ spec:
- <<: *version
name: v1beta1
served: true
storage: true
storage: false
# the schema of v1beta1 is exactly the same as v1alpha2 schema
schema:
openAPIV3Schema:
<<: *openAPIV3Schema
- <<: *version
name: v1
served: true
storage: false
storage: true
# the schema of v1 is exactly the same as v1beta1 schema
schema:
openAPIV3Schema:
Expand Down
1 change: 1 addition & 0 deletions config/post-install/clusterrole.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ rules:
- "sources.knative.dev"
resources:
- "apiserversources"
- "containersources"
verbs:
- "get"
- "list"
Expand Down
1 change: 1 addition & 0 deletions config/post-install/storage-version-migrator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,4 @@ spec:
image: ko://knative.dev/eventing/vendor/knative.dev/pkg/apiextensions/storageversion/cmd/migrate
args:
- "apiserversources.sources.knative.dev"
- "containersources.sources.knative.dev"
Copy link
Copy Markdown
Contributor

@zhongduo zhongduo Jan 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About your attention in the PR, with this post install job, when using the operator this version migration will work, right?

Copy link
Copy Markdown
Contributor

@lionelvillard lionelvillard Jan 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.

/cc @houshengbo