Skip to content

[release-0.20] Add immutable fields validation to v1beta1 broker#5028

Merged
knative-prow-robot merged 1 commit into
knative:release-0.20from
knative-prow-robot:cherry-pick-4816-to-release-0.20
Mar 9, 2021
Merged

[release-0.20] Add immutable fields validation to v1beta1 broker#5028
knative-prow-robot merged 1 commit into
knative:release-0.20from
knative-prow-robot:cherry-pick-4816-to-release-0.20

Conversation

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot commented Mar 8, 2021

This is an automated cherry-pick of #4816

@knative-prow-robot knative-prow-robot mentioned this pull request Mar 8, 2021
Merged
@knative-prow-robot knative-prow-robot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 8, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 8, 2021
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Mar 8, 2021

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/eventing/v1beta1/broker_validation.go 96.0% 88.0% -8.0

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 8, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release-0.20@b573218). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             release-0.20    #5028   +/-   ##
===============================================
  Coverage                ?   81.02%           
===============================================
  Files                   ?      291           
  Lines                   ?     8222           
  Branches                ?        0           
===============================================
  Hits                    ?     6662           
  Misses                  ?     1158           
  Partials                ?      402

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b573218...a70527c. Read the comment docs.

n3wscott
n3wscott approved these changes Mar 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor Author

knative-prow-robot commented Mar 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2021
@pierDipi
Copy link
Copy Markdown
Member

pierDipi commented Mar 9, 2021

/retest

@knative-prow-robot knative-prow-robot merged commit 5e40fe4 into knative:release-0.20 Mar 9, 2021
matzew pushed a commit to matzew/eventing that referenced this pull request Mar 15, 2021
@knative-prow-robot @cathyzhyi @matzew
Add immutable fields validation to v1beta1 broker (knative#5028)
23f2d6a 
Co-authored-by: Yi Zhang <cathyzhyi@google.com>
openshift-merge-robot pushed a commit to openshift/knative-eventing that referenced this pull request Mar 26, 2021
@matzew @knative-prow-robot @cathyzhyi
Add immutable fields validation to v1beta1 broker (knative#5028) (#1152)
208aed8 
Co-authored-by: Yi Zhang <cathyzhyi@google.com>

Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com>
Co-authored-by: Yi Zhang <cathyzhyi@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@n3wscott n3wscott n3wscott approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vaikas vaikas

@n3wscott n3wscott

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@knative-prow-robot @knative-metrics-robot @pierDipi @n3wscott @vaikas @cathyzhyi