Skip to content
This repository was archived by the owner on Nov 28, 2022. It is now read-only.

[0.20 backport] Add immutable fields validation to v1beta1 broker (#5028)#1152

Merged
openshift-merge-robot merged 1 commit into
openshift:release-v0.20.0from
matzew:broker_immutable_fields_0.20
Mar 26, 2021
Merged

[0.20 backport] Add immutable fields validation to v1beta1 broker (#5028)#1152
openshift-merge-robot merged 1 commit into
openshift:release-v0.20.0from
matzew:broker_immutable_fields_0.20

Conversation

@matzew
Copy link
Copy Markdown
Member

@matzew matzew commented Mar 15, 2021

Co-authored-by: Yi Zhang cathyzhyi@google.com

/hold

Co-authored-by: Yi Zhang <cathyzhyi@google.com>
@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2021
@matzew matzew changed the title Add immutable fields validation to v1beta1 broker (#5028) [0.20 backport] Add immutable fields validation to v1beta1 broker (#5028) Mar 15, 2021
@aliok
Copy link
Copy Markdown
Member

aliok commented Mar 16, 2021

/retest

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Mar 17, 2021

@aliok
Copy link
Copy Markdown
Member

aliok commented Mar 26, 2021

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2021
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Mar 26, 2021

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2021
@matzew
Copy link
Copy Markdown
Member Author

matzew commented Mar 26, 2021

/test all

@openshift-merge-robot openshift-merge-robot merged commit 208aed8 into openshift:release-v0.20.0 Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants