KafkaChannel hack to upgrade by slinkydeveloper · Pull Request #5085 · knative/eventing

slinkydeveloper · 2021-03-17T10:39:37Z

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

For more details knative-extensions/eventing-kafka#426 (comment)

/hold

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

codecov · 2021-03-17T10:46:38Z

Codecov Report

Merging #5085 (a8a50cc) into main (b2ea385) will increase coverage by 0.15%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #5085      +/-   ##
==========================================
+ Coverage   83.10%   83.26%   +0.15%     
==========================================
  Files         283      283              
  Lines        7947     7957      +10     
==========================================
+ Hits         6604     6625      +21     
+ Misses        968      958      -10     
+ Partials      375      374       -1

Impacted Files	Coverage Δ
pkg/apis/messaging/v1/subscription_defaults.go	`33.33% <0.00%> (-66.67%)`	⬇️
...kg/apis/messaging/v1beta1/subscription_defaults.go	`33.33% <0.00%> (-66.67%)`	⬇️
pkg/apis/messaging/v1/subscription_validation.go	`81.39% <100.00%> (+1.39%)`	⬆️
.../apis/messaging/v1beta1/subscription_validation.go	`79.48% <100.00%> (+1.70%)`	⬆️
pkg/apis/eventing/v1/trigger_types.go	`100.00% <0.00%> (ø)`
pkg/apis/eventing/v1beta1/trigger_types.go	`100.00% <0.00%> (ø)`
pkg/reconciler/apiserversource/apiserversource.go	`79.48% <0.00%> (+12.82%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2ea385...a8a50cc. Read the comment docs.

matzew · 2021-03-17T15:29:42Z

/lgtm

/assign @vaikas

matzew

/lgtm
/approve

/go-in

aliok

/lgtm
/approve

slinkydeveloper · 2021-03-18T08:31:53Z

/unhold

aliok · 2021-03-18T08:42:59Z

The discussion is here: knative-extensions/eventing-kafka#426

slinkydeveloper · 2021-03-18T09:04:10Z

/retest

slinkydeveloper · 2021-03-18T09:36:10Z

/retest

slinkydeveloper · 2021-03-18T09:46:22Z

/retest

slinkydeveloper · 2021-03-18T09:54:48Z

/hold

I have another idea

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

matzew · 2021-03-18T09:59:29Z

/lgtm
/approve

slinkydeveloper · 2021-03-18T10:11:01Z

Nope no change:

Spec:
  Channel:
    API Version:  messaging.knative.dev/v1alpha1
    Kind:         KafkaChannel
    Name:         testchannel

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

knative-metrics-robot · 2021-03-18T11:17:48Z

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/messaging/v1/subscription_defaults.go	100.0%	66.7%	-33.3
pkg/apis/messaging/v1/subscription_validation.go	94.1%	94.6%	0.5
pkg/apis/messaging/v1beta1/subscription_defaults.go	100.0%	66.7%	-33.3
pkg/apis/messaging/v1beta1/subscription_validation.go	93.3%	93.9%	0.6

slinkydeveloper · 2021-03-18T16:39:37Z

This thing now works knative-extensions/eventing-kafka#426 (comment)

slinkydeveloper · 2021-03-18T16:39:50Z

/unhold

vaikas · 2021-03-19T00:18:48Z

/lgtm
/approve

knative-prow-robot · 2021-03-19T00:18:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew, n3wscott, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [aliok,matzew,n3wscott,vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

aliok · 2021-03-19T06:56:39Z

/test pull-knative-eventing-reconciler-tests

* KafkaChannel hack Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * This hack will do the trick? Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * This is a proper hack Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * fmt Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

KafkaChannel hack

11bfab0

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2021

google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 17, 2021

knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 17, 2021

slinkydeveloper mentioned this pull request Mar 17, 2021

Remove usage of eventing duck v1alpha1 shapes knative-extensions/eventing-kafka#426

Closed

knative-prow-robot assigned vaikas and matzew Mar 17, 2021

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2021

n3wscott approved these changes Mar 17, 2021

View reviewed changes

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2021

matzew approved these changes Mar 18, 2021

View reviewed changes

aliok approved these changes Mar 18, 2021

View reviewed changes

knative-prow-robot assigned aliok Mar 18, 2021

knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2021

knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2021

This hack will do the trick?

c5082c5

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 18, 2021

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2021

This is a proper hack

8679b1b

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 18, 2021

fmt

a8a50cc

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

matzew mentioned this pull request Mar 18, 2021

Post install script, part 2 knative-extensions/eventing-kafka#473

Merged

knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2021

vaikas approved these changes Mar 19, 2021

View reviewed changes

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2021

knative-prow-robot merged commit c42772d into knative:main Mar 19, 2021

slinkydeveloper deleted the kafkachannel_hack branch March 19, 2021 08:25

slinkydeveloper mentioned this pull request Apr 19, 2021

Remove KafkaChannel upgrade hack #5276

Merged

Conversation

slinkydeveloper commented Mar 17, 2021

Uh oh!

codecov Bot commented Mar 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

matzew commented Mar 17, 2021

Uh oh!

matzew left a comment

Choose a reason for hiding this comment

Uh oh!

aliok left a comment

Choose a reason for hiding this comment

Uh oh!

slinkydeveloper commented Mar 18, 2021

Uh oh!

aliok commented Mar 18, 2021

Uh oh!

slinkydeveloper commented Mar 18, 2021

Uh oh!

slinkydeveloper commented Mar 18, 2021

Uh oh!

slinkydeveloper commented Mar 18, 2021

Uh oh!

slinkydeveloper commented Mar 18, 2021

Uh oh!

matzew commented Mar 18, 2021

Uh oh!

slinkydeveloper commented Mar 18, 2021

Uh oh!

knative-metrics-robot commented Mar 18, 2021

Uh oh!

slinkydeveloper commented Mar 18, 2021

Uh oh!

slinkydeveloper commented Mar 18, 2021

Uh oh!

vaikas commented Mar 19, 2021

Uh oh!

knative-prow-robot commented Mar 19, 2021

Uh oh!

aliok commented Mar 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov Bot commented Mar 17, 2021 •

edited

Loading