Skip to content

Remove KafkaChannel upgrade hack#5276

Merged
knative-prow-robot merged 1 commit into
knative:mainfrom
slinkydeveloper:remove_migration_hacks
Apr 19, 2021
Merged

Remove KafkaChannel upgrade hack#5276
knative-prow-robot merged 1 commit into
knative:mainfrom
slinkydeveloper:remove_migration_hacks

Conversation

@slinkydeveloper
Copy link
Copy Markdown
Contributor

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Reverts #5085, which was required in 0.22 release to upgrade kafka channel

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 19, 2021
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 19, 2021
@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/messaging/v1/subscription_defaults.go 66.7% 100.0% 33.3
pkg/apis/messaging/v1/subscription_validation.go 94.6% 94.1% -0.5

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 19, 2021

Codecov Report

Merging #5276 (12a0216) into main (97c0d30) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5276      +/-   ##
==========================================
+ Coverage   83.34%   83.36%   +0.01%     
==========================================
  Files         243      243              
  Lines        6882     6878       -4     
==========================================
- Hits         5736     5734       -2     
+ Misses        797      796       -1     
+ Partials      349      348       -1     
Impacted Files Coverage Δ
pkg/apis/messaging/v1/subscription_defaults.go 100.00% <100.00%> (+66.66%) ⬆️
pkg/apis/messaging/v1/subscription_validation.go 80.00% <100.00%> (-1.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97c0d30...12a0216. Read the comment docs.

Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2021
@knative-prow-robot knative-prow-robot merged commit 96a4cc3 into knative:main Apr 19, 2021
@slinkydeveloper slinkydeveloper deleted the remove_migration_hacks branch April 19, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants