Skip to content

Update OWNERS_ALIASES to match autogen in community#5188

Merged
knative-prow-robot merged 4 commits into
knative:mainfrom
evankanderson:owner-gen
May 5, 2021
Merged

Update OWNERS_ALIASES to match autogen in community#5188
knative-prow-robot merged 4 commits into
knative:mainfrom
evankanderson:owner-gen

Conversation

@evankanderson
Copy link
Copy Markdown
Member

@evankanderson evankanderson commented Apr 1, 2021

See knative/community#552 for the addition of groups/full OWNERS_ALIASES that will be synced.

This is a preparatory PR for landing OWNERS_ALIASES automation across the Knative org (alternative to the CODEOWNERS changes in knative-sandbox).

If this seems to be expanding permissions or otherwise likely to cause a problem, /hold this PR and comment here or on knative/community#552.

@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 1, 2021
@knative-prow-robot knative-prow-robot added area/performance area/test-and-release Test infrastructure, tests or release size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 1, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2021 •
edited
Loading

Codecov Report

Merging #5188 (dcee4cf) into main (5dccb29) will decrease coverage by 1.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5188      +/-   ##
==========================================
- Coverage   83.68%   82.35%   -1.34%     
==========================================
  Files         243      194      -49     
  Lines        6896     6002     -894     
==========================================
- Hits         5771     4943     -828     
+ Misses        783      737      -46     
+ Partials      342      322      -20
Impacted Files Coverage Δ
pkg/apis/sources/v1beta2/ping_conversion.go 60.00% <0.00%> (-40.00%) ⬇️
pkg/reconciler/subscription/subscription.go 82.12% <0.00%> (-0.08%) ⬇️
pkg/apis/sources/v1/register.go 100.00% <0.00%> (ø)
pkg/apis/sources/v1alpha2/apiserver_lifecycle.go
...kg/apis/sources/v1alpha1/sinkbinding_conversion.go
pkg/apis/sources/v1beta1/ping_validation.go
pkg/apis/sources/v1beta1/apiserver_lifecycle.go
pkg/apis/sources/v1alpha1/register.go
pkg/apis/sources/v1alpha2/ping_lifecycle.go
pkg/apis/sources/v1beta1/sinkbinding_types.go
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dccb29...dcee4cf. Read the comment docs.

@evankanderson
Copy link
Copy Markdown
Member Author

evankanderson commented Apr 1, 2021

/retest

@evankanderson
Copy link
Copy Markdown
Member Author

evankanderson commented Apr 1, 2021

/assign @vaikas

@matzew
Copy link
Copy Markdown
Member

matzew commented Apr 6, 2021

/lgtm

/cc @lionelvillard or @vaikas for final approvals

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Apr 6, 2021

@matzew: GitHub didn't allow me to request PR reviews from the following users: or, for, final, approvals.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/lgtm

/cc @lionelvillard or @vaikas for final approvals

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2021
vaikas
vaikas reviewed Apr 7, 2021
View reviewed changes
Comment thread OWNERS_ALIASES
- markusthoemmes
- mattmoor
- tcnghia
- rhuss
Copy link
Copy Markdown
Contributor

@vaikas vaikas Apr 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while updating, consider removing mattmoor?

Copy link
Copy Markdown
Member Author

@evankanderson evankanderson Apr 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be a PR tomorrow that will take Matt out (the one that you approved in knative/community#552)

Removed now.

vaikas
vaikas approved these changes Apr 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@vaikas vaikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2021
@evankanderson
Copy link
Copy Markdown
Member Author

evankanderson commented Apr 23, 2021

/retest

1 similar comment
@evankanderson
Copy link
Copy Markdown
Member Author

evankanderson commented Apr 23, 2021

/retest

@evankanderson
Copy link
Copy Markdown
Member Author

evankanderson commented Apr 27, 2021

Synced because /retest wasn't getting the test to pass. Will need another /lgtm

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 27, 2021
@evankanderson
Copy link
Copy Markdown
Member Author

evankanderson commented May 5, 2021

/verify-owners

@knative-prow-robot knative-prow-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label May 5, 2021
vaikas
vaikas approved these changes May 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@vaikas vaikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented May 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit b9f26ac into knative:main May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

1 more reviewer

@vaikas vaikas vaikas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@matzew matzew

@vaikas vaikas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/performance area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@evankanderson @matzew @knative-prow-robot @vaikas